fix: well layer: enhance well name display to avoid cluttering by nilscb · Pull Request #2433 · equinor/webviz-subsurface-components

nilscb · 2025-02-03T14:32:44Z

Simplified some code
Make sure label stays visible when camera changes.
fix bug "well layer: wellNameAtTop control is inverted well layer: wellNameAtTop control is inverted #2432" already done by fix: wellNamePosition behavior is inverted when specifying a boolean #2434

typescript/packages/subsurface-viewer/src/storybook/layers/WellsLayer.stories.tsx

typescript/packages/subsurface-viewer/src/layers/wells/wellsLayer.ts

w1nklr · 2025-02-03T14:49:44Z

typescript/packages/subsurface-viewer/src/layers/wells/wellsLayer.ts

+        const percentages = [50, 25, 75, 12.5, 87.5, 25, 75];
+
        const n = well_xyz?.length ?? 2;
        if (well_xyz && n >= 2) {


Add some comments to explain the algorithm (are a ref to original if it comes from a known algo)

BTW, I don't get the logic. If I understand correctly, if the algo fail with the provided percentage, a hard-coded list of percentages completely unrelated to the requested one is used.

Please wait a bit with this code review. The Wellslayer.stories file is included by mistake

This comment is not related to story, but to wellsLayer.ts

This is a regular sampling along the trajectory in search of a camera visible location. It is shuffled to minimize large jumps and to tend towards the middle.

What bothers me is that it does absolutely not take into account requested position.
I would use an approach to shift away from the requested position , not to ignore it

What bothers me is that it does absolutely not take into account requested position.
I would use an approach to shift away from the requested position , not to ignore it

I agree, it could be better usability if the labels shifted more gradually from the requested position instead of popping up at a random position.

nilscb · 2025-02-04T13:58:07Z

The auto positioning of lables is now default off and controlled by the well property "wellNameAutoPosition"

w1nklr · 2025-02-04T08:08:04Z

typescript/packages/subsurface-viewer/src/layers/wells/wellsLayer.ts

+        const percentages = [50, 25, 75, 12.5, 87.5, 25, 75];
+
        const n = well_xyz?.length ?? 2;
        if (well_xyz && n >= 2) {


This comment is not related to story, but to wellsLayer.ts

w1nklr · 2025-02-04T16:15:34Z

typescript/packages/subsurface-viewer/src/layers/wells/wellsLayer.ts

+    /** It true label position will be auto calculated if possible to be inside view volume at all times.
+     *  default false.
+     */
+    wellNameAutoPosition: boolean;


I would rename that to adjustWellNamePosition

w1nklr · 2025-02-04T16:21:09Z

typescript/packages/subsurface-viewer/src/layers/wells/wellsLayer.ts

+        const percentages = [50, 25, 75, 12.5, 87.5, 25, 75];
+
        const n = well_xyz?.length ?? 2;
        if (well_xyz && n >= 2) {


What bothers me is that it does absolutely not take into account requested position.
I would use an approach to shift away from the requested position , not to ignore it

hkfb · 2025-02-06T09:36:23Z

If I disable hideOverlappingWellNames then all labels disappear, which is unexpected:

hkfb

It also appears that if you provoke a 90 degree angle on the labels by rotating the camera, then the labels disappear.

@nilscb

Continuation of #2433 Fixes #767 and #947 Summary of changes: * @nilscb added functionality for positioning and backgrounds for well labels * Extracted a new deck.gl layer `WellLabelLayer` which is used to render labels in the `WellsLayer`. Its props can be specified using the `wellLabel` prop in `WellsLayer` * In order to prevent z buffer fighting, z coordinates were modified by @nilscb. I modified it slightly so that a single layer can display consistently in both Orthographic and Orbit views. I also narrowed the near and far plane scope for Orthographic views in order to further reduce z buffer collision. * Created some stories to demonstrate the styling and positioning options for well labels * Added procedurally generated synthetic wells in order to demonstrate the above ![image](https://github.com/user-attachments/assets/00bef14d-c479-45ce-bd8e-36f39c1faf4c) --------- Co-authored-by: Nils Christian Bonnevie <nils.christian.bonnevie@gmail.com>

# [1.10.0](https://github.com/equinor/webviz-subsurface-components/compare/subsurface-viewer@1.9.0...subsurface-viewer@1.10.0) (2025-03-27) ### Features * enhanced well label styling ([#2487](#2487)) ([a4569fe](a4569fe)), closes [#2433](#2433) [#767](#767) [#947](#947)

hkfb · 2025-03-28T07:12:22Z

@nilscb ok to close this PR, since it was superceded by #2487?

w1nklr · 2025-03-28T09:29:52Z

@nilscb ok to close this PR, since it was superceded by #2487?

Fine for me

## [0.6.4](https://github.com/equinor/webviz-subsurface-components/compare/wsc-common@0.6.3...wsc-common@0.6.4) (2024-05-29) ### Bug Fixes * bump ajv from 8.12.0 to 8.14.0 in /typescript ([equinor#2075](equinor#2075)) ([e7194a4](equinor@e7194a4)), closes [ajv-validator/ajv#2424](ajv-validator/ajv#2424) [ajv-validator/ajv#2410](ajv-validator/ajv#2410) [ajv-validator/ajv#2428](ajv-validator/ajv#2428) [ajv-validator/ajv#2431](ajv-validator/ajv#2431) [equinor#2427](equinor#2427) [ajv-validator/ajv#2433](ajv-validator/ajv#2433) [ajv-validator/ajv#2440](ajv-validator/ajv#2440) [ajv-validator/ajv#2410](ajv-validator/ajv#2410) [equinor#2440](equinor#2440) [equinor#2427](equinor#2427) [equinor#2433](equinor#2433) [equinor#2431](equinor#2431) [equinor#2428](equinor#2428) [equinor#2410](equinor#2410) [equinor#2424](equinor#2424) [equinor#2423](equinor#2423) [equinor#2421](equinor#2421) [equinor#2406](equinor#2406) [equinor#2402](equinor#2402)

## [1.2.16](https://github.com/equinor/webviz-subsurface-components/compare/well-completions-plot@1.2.15...well-completions-plot@1.2.16) (2024-05-29) ### Bug Fixes * bump ajv from 8.12.0 to 8.14.0 in /typescript ([equinor#2075](equinor#2075)) ([e7194a4](equinor@e7194a4)), closes [ajv-validator/ajv#2424](ajv-validator/ajv#2424) [ajv-validator/ajv#2410](ajv-validator/ajv#2410) [ajv-validator/ajv#2428](ajv-validator/ajv#2428) [ajv-validator/ajv#2431](ajv-validator/ajv#2431) [equinor#2427](equinor#2427) [ajv-validator/ajv#2433](ajv-validator/ajv#2433) [ajv-validator/ajv#2440](ajv-validator/ajv#2440) [ajv-validator/ajv#2410](ajv-validator/ajv#2410) [equinor#2440](equinor#2440) [equinor#2427](equinor#2427) [equinor#2433](equinor#2433) [equinor#2431](equinor#2431) [equinor#2428](equinor#2428) [equinor#2410](equinor#2410) [equinor#2424](equinor#2424) [equinor#2423](equinor#2423) [equinor#2421](equinor#2421) [equinor#2406](equinor#2406) [equinor#2402](equinor#2402)

## [1.8.1](https://github.com/equinor/webviz-subsurface-components/compare/well-log-viewer@1.8.0...well-log-viewer@1.8.1) (2024-05-29) ### Bug Fixes * bump ajv from 8.12.0 to 8.14.0 in /typescript ([equinor#2075](equinor#2075)) ([e7194a4](equinor@e7194a4)), closes [ajv-validator/ajv#2424](ajv-validator/ajv#2424) [ajv-validator/ajv#2410](ajv-validator/ajv#2410) [ajv-validator/ajv#2428](ajv-validator/ajv#2428) [ajv-validator/ajv#2431](ajv-validator/ajv#2431) [equinor#2427](equinor#2427) [ajv-validator/ajv#2433](ajv-validator/ajv#2433) [ajv-validator/ajv#2440](ajv-validator/ajv#2440) [ajv-validator/ajv#2410](ajv-validator/ajv#2410) [equinor#2440](equinor#2440) [equinor#2427](equinor#2427) [equinor#2433](equinor#2433) [equinor#2431](equinor#2431) [equinor#2428](equinor#2428) [equinor#2410](equinor#2410) [equinor#2424](equinor#2424) [equinor#2423](equinor#2423) [equinor#2421](equinor#2421) [equinor#2406](equinor#2406) [equinor#2402](equinor#2402)

nilscb linked an issue Feb 3, 2025 that may be closed by this pull request

well layer: wellNameAtTop control is inverted #2432

Closed

nilscb self-assigned this Feb 3, 2025

nilscb added bug Something isn't working AspenTech Task owned by AspenTech map-component Issues related to the map component. labels Feb 3, 2025

w1nklr requested changes Feb 3, 2025

View reviewed changes

nilscb force-pushed the WellClutterContinued branch from 6af52bb to 0537835 Compare February 3, 2025 15:10

w1nklr requested changes Feb 4, 2025

View reviewed changes

hkfb requested changes Feb 6, 2025

View reviewed changes

w1nklr changed the title ~~fix: well layer: wellNameAtTop control is inverted #2432~~ fix: well layer: enhance well name display to avoid cluttering Feb 13, 2025

nilscb closed this Mar 14, 2025

nilscb reopened this Mar 14, 2025

nilscb marked this pull request as draft March 14, 2025 13:41

nilscb force-pushed the WellClutterContinued branch 2 times, most recently from b0e9d0e to 41bbb82 Compare March 18, 2025 13:40

fix: well layer: enhance well name display to avoid cluttering

886b71a

nilscb force-pushed the WellClutterContinued branch from 41bbb82 to 886b71a Compare March 18, 2025 13:41

hkfb linked an issue Mar 19, 2025 that may be closed by this pull request

[NGRM] - Remove well name clutter on map #947

Closed

hkfb mentioned this pull request Mar 24, 2025

feat: enhanced well label styling #2487

Merged

hkfb closed this Mar 28, 2025

Conversation

nilscb commented Feb 3, 2025 • edited by w1nklr Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nilscb commented Feb 4, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hkfb commented Feb 6, 2025

Uh oh!

hkfb left a comment

Choose a reason for hiding this comment

Uh oh!

hkfb commented Mar 28, 2025

Uh oh!

w1nklr commented Mar 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nilscb commented Feb 3, 2025 •

edited by w1nklr

Loading