fix: Well Log Viewer - Moved callback subscription to well-log-viewer mounted hook#2217
Merged
hkfb merged 1 commit intoequinor:masterfrom Sep 3, 2024
Conversation
mirisb
approved these changes
Sep 2, 2024
hkfb
pushed a commit
to hkfb/webviz-subsurface-components
that referenced
this pull request
Sep 2, 2024
## [0.6.6](https://github.com/equinor/webviz-subsurface-components/compare/wsc-common@0.6.5...wsc-common@0.6.6) (2024-07-18) ### Bug Fixes * bump @equinor/videx-wellog from 0.9.4 to 0.10.0 in /typescript ([equinor#2120](equinor#2120)) ([614bc81](equinor@614bc81)) * bump @turf/simplify from 6.5.0 to 7.0.0 in /typescript ([equinor#2144](equinor#2144)) ([888d147](equinor@888d147)), closes [/github.com/Turfjs/turf/blob/master/CHANGELOG.md#700](https://github.com//github.com/Turfjs/turf/blob/master/CHANGELOG.md/issues/700) [equinor#2158](equinor#2158) [equinor#2237](equinor#2237) [equinor#2177](equinor#2177) [equinor#2173](equinor#2173) [equinor#2393](equinor#2393) [equinor#2166](equinor#2166) [equinor#2183](equinor#2183) [equinor#2106](equinor#2106) [equinor#2106](equinor#2106) [equinor#2247](equinor#2247) [equinor#2247](equinor#2247) [equinor#2247](equinor#2247) [equinor#2613](equinor#2613) [equinor#1896](equinor#1896) [equinor#2217](equinor#2217) [equinor#2231](equinor#2231) [equinor#1893](equinor#1893) [equinor#2033](equinor#2033) [equinor#2338](equinor#2338) [equinor#2415](equinor#2415) [equinor#1450](equinor#1450) [equinor#2149](equinor#2149) [equinor#2323](equinor#2323) [equinor#2142](equinor#2142) [equinor#2316](equinor#2316) [equinor#2345](equinor#2345) [equinor#2178](equinor#2178) [equinor#2168](equinor#2168) [equinor#2174](equinor#2174) [equinor#2182](equinor#2182) [equinor#2171](equinor#2171) [equinor#2171](equinor#2171) [equinor#2167](equinor#2167) [equinor#2134](equinor#2134) [equinor#2169](equinor#2169) [equinor#2195](equinor#2195) [equinor#2216](equinor#2216) [equinor#2227](equinor#2227) [equinor#2172](equinor#2172) [equinor#2475](equinor#2475) [equinor#2504](equinor#2504) [equinor#2524](equinor#2524) [equinor#2609](equinor#2609) [equinor#2607](equinor#2607) [equinor#2603](equinor#2603) [equinor#2599](equinor#2599) [equinor#2565](equinor#2565) [equinor#2576](equinor#2576) [equinor#2572](equinor#2572) [equinor#2571](equinor#2571) * bump ajv from 8.14.0 to 8.16.0 in /typescript ([equinor#2138](equinor#2138)) ([3f02100](equinor@3f02100)), closes [ajv-validator/ajv#2444](ajv-validator/ajv#2444) [ajv-validator/ajv#2415](ajv-validator/ajv#2415) [ajv-validator/ajv#2442](ajv-validator/ajv#2442) [ajv-validator/ajv#2415](ajv-validator/ajv#2415) [equinor#2444](equinor#2444) [equinor#2442](equinor#2442) [equinor#2415](equinor#2415) * bump mathjs from 12.4.2 to 13.0.0 in /typescript ([equinor#2124](equinor#2124)) ([caae3f2](equinor@caae3f2)), closes [#3223](https://github.com/equinor/webviz-subsurface-components/issues/3223) [#3139](https://github.com/equinor/webviz-subsurface-components/issues/3139) [#2838](https://github.com/equinor/webviz-subsurface-components/issues/2838) [#3152](https://github.com/equinor/webviz-subsurface-components/issues/3152) [#2838](https://github.com/equinor/webviz-subsurface-components/issues/2838) [rawify/Fraction.js#68](rawify/Fraction.js#68) [#3207](https://github.com/equinor/webviz-subsurface-components/issues/3207) [#3207](https://github.com/equinor/webviz-subsurface-components/issues/3207) [#3207](https://github.com/equinor/webviz-subsurface-components/issues/3207) [equinor#1240](equinor#1240) [#3189](https://github.com/equinor/webviz-subsurface-components/issues/3189) [#3197](https://github.com/equinor/webviz-subsurface-components/issues/3197) [#3198](https://github.com/equinor/webviz-subsurface-components/issues/3198) * semantic release not publishing ([equinor#2160](equinor#2160)) ([235c558](equinor@235c558)) * semantic release not publishing ([equinor#2164](equinor#2164)) ([9878239](equinor@9878239))
hkfb
pushed a commit
to hkfb/webviz-subsurface-components
that referenced
this pull request
Sep 2, 2024
## [1.2.18](https://github.com/equinor/webviz-subsurface-components/compare/well-completions-plot@1.2.17...well-completions-plot@1.2.18) (2024-07-18) ### Bug Fixes * bump @equinor/videx-wellog from 0.9.4 to 0.10.0 in /typescript ([equinor#2120](equinor#2120)) ([614bc81](equinor@614bc81)) * bump @turf/simplify from 6.5.0 to 7.0.0 in /typescript ([equinor#2144](equinor#2144)) ([888d147](equinor@888d147)), closes [/github.com/Turfjs/turf/blob/master/CHANGELOG.md#700](https://github.com//github.com/Turfjs/turf/blob/master/CHANGELOG.md/issues/700) [equinor#2158](equinor#2158) [equinor#2237](equinor#2237) [equinor#2177](equinor#2177) [equinor#2173](equinor#2173) [equinor#2393](equinor#2393) [equinor#2166](equinor#2166) [equinor#2183](equinor#2183) [equinor#2106](equinor#2106) [equinor#2106](equinor#2106) [equinor#2247](equinor#2247) [equinor#2247](equinor#2247) [equinor#2247](equinor#2247) [equinor#2613](equinor#2613) [equinor#1896](equinor#1896) [equinor#2217](equinor#2217) [equinor#2231](equinor#2231) [equinor#1893](equinor#1893) [equinor#2033](equinor#2033) [equinor#2338](equinor#2338) [equinor#2415](equinor#2415) [equinor#1450](equinor#1450) [equinor#2149](equinor#2149) [equinor#2323](equinor#2323) [equinor#2142](equinor#2142) [equinor#2316](equinor#2316) [equinor#2345](equinor#2345) [equinor#2178](equinor#2178) [equinor#2168](equinor#2168) [equinor#2174](equinor#2174) [equinor#2182](equinor#2182) [equinor#2171](equinor#2171) [equinor#2171](equinor#2171) [equinor#2167](equinor#2167) [equinor#2134](equinor#2134) [equinor#2169](equinor#2169) [equinor#2195](equinor#2195) [equinor#2216](equinor#2216) [equinor#2227](equinor#2227) [equinor#2172](equinor#2172) [equinor#2475](equinor#2475) [equinor#2504](equinor#2504) [equinor#2524](equinor#2524) [equinor#2609](equinor#2609) [equinor#2607](equinor#2607) [equinor#2603](equinor#2603) [equinor#2599](equinor#2599) [equinor#2565](equinor#2565) [equinor#2576](equinor#2576) [equinor#2572](equinor#2572) [equinor#2571](equinor#2571) * bump ajv from 8.14.0 to 8.16.0 in /typescript ([equinor#2138](equinor#2138)) ([3f02100](equinor@3f02100)), closes [ajv-validator/ajv#2444](ajv-validator/ajv#2444) [ajv-validator/ajv#2415](ajv-validator/ajv#2415) [ajv-validator/ajv#2442](ajv-validator/ajv#2442) [ajv-validator/ajv#2415](ajv-validator/ajv#2415) [equinor#2444](equinor#2444) [equinor#2442](equinor#2442) [equinor#2415](equinor#2415) * bump mathjs from 12.4.2 to 13.0.0 in /typescript ([equinor#2124](equinor#2124)) ([caae3f2](equinor@caae3f2)), closes [#3223](https://github.com/equinor/webviz-subsurface-components/issues/3223) [#3139](https://github.com/equinor/webviz-subsurface-components/issues/3139) [#2838](https://github.com/equinor/webviz-subsurface-components/issues/2838) [#3152](https://github.com/equinor/webviz-subsurface-components/issues/3152) [#2838](https://github.com/equinor/webviz-subsurface-components/issues/2838) [rawify/Fraction.js#68](rawify/Fraction.js#68) [#3207](https://github.com/equinor/webviz-subsurface-components/issues/3207) [#3207](https://github.com/equinor/webviz-subsurface-components/issues/3207) [#3207](https://github.com/equinor/webviz-subsurface-components/issues/3207) [equinor#1240](equinor#1240) [#3189](https://github.com/equinor/webviz-subsurface-components/issues/3189) [#3197](https://github.com/equinor/webviz-subsurface-components/issues/3197) [#3198](https://github.com/equinor/webviz-subsurface-components/issues/3198) * semantic release not publishing ([equinor#2160](equinor#2160)) ([235c558](equinor@235c558)) * semantic release not publishing ([equinor#2164](equinor#2164)) ([9878239](equinor@9878239))
hkfb
pushed a commit
to hkfb/webviz-subsurface-components
that referenced
this pull request
Sep 2, 2024
## [0.27.10](https://github.com/equinor/webviz-subsurface-components/compare/subsurface-viewer@0.27.9...subsurface-viewer@0.27.10) (2024-07-18) ### Bug Fixes * [NGRM] - Strange artefacts in 2D maps [equinor#2134](equinor#2134) ([equinor#2135](equinor#2135)) ([0446493](equinor@0446493)) * bump @equinor/videx-wellog from 0.9.4 to 0.10.0 in /typescript ([equinor#2120](equinor#2120)) ([614bc81](equinor@614bc81)) * bump @turf/simplify from 6.5.0 to 7.0.0 in /typescript ([equinor#2144](equinor#2144)) ([888d147](equinor@888d147)), closes [/github.com/Turfjs/turf/blob/master/CHANGELOG.md#700](https://github.com//github.com/Turfjs/turf/blob/master/CHANGELOG.md/issues/700) [equinor#2158](equinor#2158) [equinor#2237](equinor#2237) [equinor#2177](equinor#2177) [equinor#2173](equinor#2173) [equinor#2393](equinor#2393) [equinor#2166](equinor#2166) [equinor#2183](equinor#2183) [equinor#2106](equinor#2106) [equinor#2106](equinor#2106) [equinor#2247](equinor#2247) [equinor#2247](equinor#2247) [equinor#2247](equinor#2247) [equinor#2613](equinor#2613) [equinor#1896](equinor#1896) [equinor#2217](equinor#2217) [equinor#2231](equinor#2231) [equinor#1893](equinor#1893) [equinor#2033](equinor#2033) [equinor#2338](equinor#2338) [equinor#2415](equinor#2415) [equinor#1450](equinor#1450) [equinor#2149](equinor#2149) [equinor#2323](equinor#2323) [equinor#2142](equinor#2142) [equinor#2316](equinor#2316) [equinor#2345](equinor#2345) [equinor#2178](equinor#2178) [equinor#2168](equinor#2168) [equinor#2174](equinor#2174) [equinor#2182](equinor#2182) [equinor#2171](equinor#2171) [equinor#2171](equinor#2171) [equinor#2167](equinor#2167) [equinor#2134](equinor#2134) [equinor#2169](equinor#2169) [equinor#2195](equinor#2195) [equinor#2216](equinor#2216) [equinor#2227](equinor#2227) [equinor#2172](equinor#2172) [equinor#2475](equinor#2475) [equinor#2504](equinor#2504) [equinor#2524](equinor#2524) [equinor#2609](equinor#2609) [equinor#2607](equinor#2607) [equinor#2603](equinor#2603) [equinor#2599](equinor#2599) [equinor#2565](equinor#2565) [equinor#2576](equinor#2576) [equinor#2572](equinor#2572) [equinor#2571](equinor#2571) * bump ajv from 8.14.0 to 8.16.0 in /typescript ([equinor#2138](equinor#2138)) ([3f02100](equinor@3f02100)), closes [ajv-validator/ajv#2444](ajv-validator/ajv#2444) [ajv-validator/ajv#2415](ajv-validator/ajv#2415) [ajv-validator/ajv#2442](ajv-validator/ajv#2442) [ajv-validator/ajv#2415](ajv-validator/ajv#2415) [equinor#2444](equinor#2444) [equinor#2442](equinor#2442) [equinor#2415](equinor#2415) * bump mathjs from 12.4.2 to 13.0.0 in /typescript ([equinor#2124](equinor#2124)) ([caae3f2](equinor@caae3f2)), closes [#3223](https://github.com/equinor/webviz-subsurface-components/issues/3223) [#3139](https://github.com/equinor/webviz-subsurface-components/issues/3139) [#2838](https://github.com/equinor/webviz-subsurface-components/issues/2838) [#3152](https://github.com/equinor/webviz-subsurface-components/issues/3152) [#2838](https://github.com/equinor/webviz-subsurface-components/issues/2838) [rawify/Fraction.js#68](rawify/Fraction.js#68) [#3207](https://github.com/equinor/webviz-subsurface-components/issues/3207) [#3207](https://github.com/equinor/webviz-subsurface-components/issues/3207) [#3207](https://github.com/equinor/webviz-subsurface-components/issues/3207) [equinor#1240](equinor#1240) [#3189](https://github.com/equinor/webviz-subsurface-components/issues/3189) [#3197](https://github.com/equinor/webviz-subsurface-components/issues/3197) [#3198](https://github.com/equinor/webviz-subsurface-components/issues/3198) * Changed to low precission for uniform in grid3D layer. ([equinor#2146](equinor#2146)) ([736f5e7](equinor@736f5e7)) * Fixes failing smoke test for axes2D layer. ([equinor#2150](equinor#2150)) ([240ea8d](equinor@240ea8d)) * semantic release not publishing ([equinor#2160](equinor#2160)) ([235c558](equinor@235c558)) * semantic release not publishing ([equinor#2164](equinor#2164)) ([9878239](equinor@9878239))
hkfb
pushed a commit
to hkfb/webviz-subsurface-components
that referenced
this pull request
Sep 2, 2024
## [1.1.18](https://github.com/equinor/webviz-subsurface-components/compare/group-tree-plot@1.1.17...group-tree-plot@1.1.18) (2024-07-18) ### Bug Fixes * bump @equinor/videx-wellog from 0.9.4 to 0.10.0 in /typescript ([equinor#2120](equinor#2120)) ([614bc81](equinor@614bc81)) * bump @turf/simplify from 6.5.0 to 7.0.0 in /typescript ([equinor#2144](equinor#2144)) ([888d147](equinor@888d147)), closes [/github.com/Turfjs/turf/blob/master/CHANGELOG.md#700](https://github.com//github.com/Turfjs/turf/blob/master/CHANGELOG.md/issues/700) [equinor#2158](equinor#2158) [equinor#2237](equinor#2237) [equinor#2177](equinor#2177) [equinor#2173](equinor#2173) [equinor#2393](equinor#2393) [equinor#2166](equinor#2166) [equinor#2183](equinor#2183) [equinor#2106](equinor#2106) [equinor#2106](equinor#2106) [equinor#2247](equinor#2247) [equinor#2247](equinor#2247) [equinor#2247](equinor#2247) [equinor#2613](equinor#2613) [equinor#1896](equinor#1896) [equinor#2217](equinor#2217) [equinor#2231](equinor#2231) [equinor#1893](equinor#1893) [equinor#2033](equinor#2033) [equinor#2338](equinor#2338) [equinor#2415](equinor#2415) [equinor#1450](equinor#1450) [equinor#2149](equinor#2149) [equinor#2323](equinor#2323) [equinor#2142](equinor#2142) [equinor#2316](equinor#2316) [equinor#2345](equinor#2345) [equinor#2178](equinor#2178) [equinor#2168](equinor#2168) [equinor#2174](equinor#2174) [equinor#2182](equinor#2182) [equinor#2171](equinor#2171) [equinor#2171](equinor#2171) [equinor#2167](equinor#2167) [equinor#2134](equinor#2134) [equinor#2169](equinor#2169) [equinor#2195](equinor#2195) [equinor#2216](equinor#2216) [equinor#2227](equinor#2227) [equinor#2172](equinor#2172) [equinor#2475](equinor#2475) [equinor#2504](equinor#2504) [equinor#2524](equinor#2524) [equinor#2609](equinor#2609) [equinor#2607](equinor#2607) [equinor#2603](equinor#2603) [equinor#2599](equinor#2599) [equinor#2565](equinor#2565) [equinor#2576](equinor#2576) [equinor#2572](equinor#2572) [equinor#2571](equinor#2571) * bump ajv from 8.14.0 to 8.16.0 in /typescript ([equinor#2138](equinor#2138)) ([3f02100](equinor@3f02100)), closes [ajv-validator/ajv#2444](ajv-validator/ajv#2444) [ajv-validator/ajv#2415](ajv-validator/ajv#2415) [ajv-validator/ajv#2442](ajv-validator/ajv#2442) [ajv-validator/ajv#2415](ajv-validator/ajv#2415) [equinor#2444](equinor#2444) [equinor#2442](equinor#2442) [equinor#2415](equinor#2415) * bump mathjs from 12.4.2 to 13.0.0 in /typescript ([equinor#2124](equinor#2124)) ([caae3f2](equinor@caae3f2)), closes [#3223](https://github.com/equinor/webviz-subsurface-components/issues/3223) [#3139](https://github.com/equinor/webviz-subsurface-components/issues/3139) [#2838](https://github.com/equinor/webviz-subsurface-components/issues/2838) [#3152](https://github.com/equinor/webviz-subsurface-components/issues/3152) [#2838](https://github.com/equinor/webviz-subsurface-components/issues/2838) [rawify/Fraction.js#68](rawify/Fraction.js#68) [#3207](https://github.com/equinor/webviz-subsurface-components/issues/3207) [#3207](https://github.com/equinor/webviz-subsurface-components/issues/3207) [#3207](https://github.com/equinor/webviz-subsurface-components/issues/3207) [equinor#1240](equinor#1240) [#3189](https://github.com/equinor/webviz-subsurface-components/issues/3189) [#3197](https://github.com/equinor/webviz-subsurface-components/issues/3197) [#3198](https://github.com/equinor/webviz-subsurface-components/issues/3198) * semantic release not publishing ([equinor#2160](equinor#2160)) ([235c558](equinor@235c558)) * semantic release not publishing ([equinor#2164](equinor#2164)) ([9878239](equinor@9878239))
hkfb
pushed a commit
to hkfb/webviz-subsurface-components
that referenced
this pull request
Sep 2, 2024
# [1.11.0](https://github.com/equinor/webviz-subsurface-components/compare/well-log-viewer@1.10.1...well-log-viewer@1.11.0) (2024-07-18) ### Bug Fixes * bump @equinor/videx-wellog from 0.9.4 to 0.10.0 in /typescript ([equinor#2120](equinor#2120)) ([614bc81](equinor@614bc81)) * bump @turf/simplify from 6.5.0 to 7.0.0 in /typescript ([equinor#2144](equinor#2144)) ([888d147](equinor@888d147)), closes [/github.com/Turfjs/turf/blob/master/CHANGELOG.md#700](https://github.com//github.com/Turfjs/turf/blob/master/CHANGELOG.md/issues/700) [equinor#2158](equinor#2158) [equinor#2237](equinor#2237) [equinor#2177](equinor#2177) [equinor#2173](equinor#2173) [equinor#2393](equinor#2393) [equinor#2166](equinor#2166) [equinor#2183](equinor#2183) [equinor#2106](equinor#2106) [equinor#2106](equinor#2106) [equinor#2247](equinor#2247) [equinor#2247](equinor#2247) [equinor#2247](equinor#2247) [equinor#2613](equinor#2613) [equinor#1896](equinor#1896) [equinor#2217](equinor#2217) [equinor#2231](equinor#2231) [equinor#1893](equinor#1893) [equinor#2033](equinor#2033) [equinor#2338](equinor#2338) [equinor#2415](equinor#2415) [equinor#1450](equinor#1450) [equinor#2149](equinor#2149) [equinor#2323](equinor#2323) [equinor#2142](equinor#2142) [equinor#2316](equinor#2316) [equinor#2345](equinor#2345) [equinor#2178](equinor#2178) [equinor#2168](equinor#2168) [equinor#2174](equinor#2174) [equinor#2182](equinor#2182) [equinor#2171](equinor#2171) [equinor#2171](equinor#2171) [equinor#2167](equinor#2167) [equinor#2134](equinor#2134) [equinor#2169](equinor#2169) [equinor#2195](equinor#2195) [equinor#2216](equinor#2216) [equinor#2227](equinor#2227) [equinor#2172](equinor#2172) [equinor#2475](equinor#2475) [equinor#2504](equinor#2504) [equinor#2524](equinor#2524) [equinor#2609](equinor#2609) [equinor#2607](equinor#2607) [equinor#2603](equinor#2603) [equinor#2599](equinor#2599) [equinor#2565](equinor#2565) [equinor#2576](equinor#2576) [equinor#2572](equinor#2572) [equinor#2571](equinor#2571) * bump ajv from 8.14.0 to 8.16.0 in /typescript ([equinor#2138](equinor#2138)) ([3f02100](equinor@3f02100)), closes [ajv-validator/ajv#2444](ajv-validator/ajv#2444) [ajv-validator/ajv#2415](ajv-validator/ajv#2415) [ajv-validator/ajv#2442](ajv-validator/ajv#2442) [ajv-validator/ajv#2415](ajv-validator/ajv#2415) [equinor#2444](equinor#2444) [equinor#2442](equinor#2442) [equinor#2415](equinor#2415) * bump mathjs from 12.4.2 to 13.0.0 in /typescript ([equinor#2124](equinor#2124)) ([caae3f2](equinor@caae3f2)), closes [#3223](https://github.com/equinor/webviz-subsurface-components/issues/3223) [#3139](https://github.com/equinor/webviz-subsurface-components/issues/3139) [#2838](https://github.com/equinor/webviz-subsurface-components/issues/2838) [#3152](https://github.com/equinor/webviz-subsurface-components/issues/3152) [#2838](https://github.com/equinor/webviz-subsurface-components/issues/2838) [rawify/Fraction.js#68](rawify/Fraction.js#68) [#3207](https://github.com/equinor/webviz-subsurface-components/issues/3207) [#3207](https://github.com/equinor/webviz-subsurface-components/issues/3207) [#3207](https://github.com/equinor/webviz-subsurface-components/issues/3207) [equinor#1240](equinor#1240) [#3189](https://github.com/equinor/webviz-subsurface-components/issues/3189) [#3197](https://github.com/equinor/webviz-subsurface-components/issues/3197) [#3198](https://github.com/equinor/webviz-subsurface-components/issues/3198) * Crash Removing Well Log in SLV ([equinor#2122](equinor#2122)) ([4139860](equinor@4139860)), closes [equinor#2114](equinor#2114) * Property "setControllerDefaultZoom" does not exist on type "WellLogController" ([equinor#2136](equinor#2136)) ([a2390e2](equinor@a2390e2)) * semantic release not publishing ([equinor#2160](equinor#2160)) ([235c558](equinor@235c558)) * semantic release not publishing ([equinor#2164](equinor#2164)) ([9878239](equinor@9878239)) * StrictMode behaviour ([equinor#2139](equinor#2139)) ([807fff4](equinor@807fff4)), closes [equinor#2110](equinor#2110) [/github.com/equinor/issues/2053#issuecomment-2194025734](https://github.com//github.com/equinor/webviz-subsurface-components/issues/2053/issues/issuecomment-2194025734) ### Features * color function ([equinor#2054](equinor#2054)) ([equinor#2152](equinor#2152)) ([36b85bb](equinor@36b85bb))
hkfb
pushed a commit
that referenced
this pull request
Sep 3, 2024
## [1.12.7](https://github.com/equinor/webviz-subsurface-components/compare/well-log-viewer@1.12.6...well-log-viewer@1.12.7) (2024-09-03) ### Bug Fixes * Well Log Viewer - Moved callback subscription to well-log-viewer mounted hook ([#2217](#2217)) ([c0e5c97](c0e5c97)), closes [#2216](#2216) [#2196](#2196)
Collaborator
|
🎉 This issue has been resolved in version well-log-viewer@1.12.7 🎉 The release is available on GitHub release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves issue #2216
The callback manager events introduced in PR #2196 where being set up in the constructor hook, not in the
componentDidMount()hook, which is against React guidelines.This PR fixes that