Explicit React CSS selector syntax description#2178
Merged
ljharb merged 1 commit intoenzymejs:masterfrom Sep 27, 2019
levimeahan:patch-1
Merged
Explicit React CSS selector syntax description#2178ljharb merged 1 commit intoenzymejs:masterfrom levimeahan:patch-1
ljharb merged 1 commit intoenzymejs:masterfrom
levimeahan:patch-1
Conversation
It is not obvious on reading through the document as-is that the CSS selector syntax works on React component names and their props. While it can be inferred through reading "The Key and Ref Props" section, that section can easily be missed when someone is specifically looking at the lists and examples of selectors to see what can be used. It is much clearer to explicitly state this syntax works on React components.
ljharb
approved these changes
Jun 30, 2019
ljharb
added a commit
that referenced
this pull request
Dec 20, 2019
New Stuff - `render`: handle Fiber strings and numbers (#2221) Fixes - `shallow`: Share child context logic between `shallow` and `dive` (#2296) - `mount`: `children`: include text nodes ($2269) - `mount`: `invoke`: use adapter’s `wrapInvoke` if present (#2158) Docs - `mount`/`shallow`: `closest`/`parent`: Add missing arguments description (#2264) - `mount`/`shallow`: fix pluralization of “exist” (#2262) - `shallow`/`mount`: `simulate`: added functional component example to simulate doc (#2248) - `mount`: `debug`: add missing verbose option flag (#2184) - `mount`/`shallow`: `update`: fix semantics description (#2194) - add missing backticks to linked method names (#2170) - `invoke`: Add missing backticks to end of codeblock (#2160) - `invoke`: Fix typo (#2167) - Explicit React CSS selector syntax description (#2178) Meta Stuff - [meta] add `funding` field - [meta] Update airbnb.io URLs to use https (#2222) - [deps] update `is-boolean-object`, `is-callable`, `is-number-object`, `is-string`, `enzyme-shallow-equal`, `array.prototype.flat`, `function.prototype.name`, `html-element-map`, `is-r egex`, `object-inspect`, `object-is`, `object.entries`, `object.vales`, `raf`, `string.prototype.trim` - [dev deps] update `eslint`, `eslint-plugin-import`, `eslint-plugin-markdown`, `eslint-plugin-react`, `safe-publish-latest`, `eslint-config-airbnb`, `rimraf`, `safe-publish-latest`, `k arma-firefox-launcher`, `babel-preset-airbnb`, `glob-gitignore`, `semver`, `eslint-plugin-jsx-a11y`
This was referenced Apr 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is not obvious on reading through the document as-is that the CSS selector syntax works on React component names and their props. While it can be inferred through reading "The Key and Ref Props" section, that section can easily be missed when someone is specifically looking at the lists and examples of selectors to see what can be used. It is much clearer to explicitly state this syntax works on React components.