[enzyme-adapter-react-16] [fix] Find memo components by constructor#2081
Merged
ljharb merged 1 commit intoenzymejs:masterfrom Apr 3, 2019
Merged
[enzyme-adapter-react-16] [fix] Find memo components by constructor#2081ljharb merged 1 commit intoenzymejs:masterfrom
ljharb merged 1 commit intoenzymejs:masterfrom
Conversation
ljharb
approved these changes
Apr 3, 2019
Member
ljharb
left a comment
There was a problem hiding this comment.
Thanks, this is excellent and much appreciated.
ljharb
added a commit
that referenced
this pull request
Apr 6, 2019
- [new] Add support for wrapping `Profiler` (#2055) - [new] support shallow rendering `createContext()` providers and consumers - add `isContextConsumer`, `getProviderFromConsumer` (#1966) - [new] add `wrapWithWrappingComponent`, `isCustomComponent` (#1960) - [new] add `getDerivedStateFromError` support (#2036) - [fix] avoid invariant violation in provider (#2083) - [fix] properly fix finding memo(SFC) components (#2081) - [fix] properly render memoized SFCs - [fix] `shallow`: avoid wrapping component for hooks - [deps] update `react-is` - [dev deps] update `eslint` - [refactor] use `react-is` predicates more - [build] include source maps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on 4149a21 which attempted to fix #2038. The fix was not working for the scenario described in #2038 (comment).
This PR adds a test for the scenario above and fixes that issue.