Conversation
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
|
performed a full iteration on the proposed release procedure in 2aee23e, this is ready for another look |
RELEASE_PROCEDURE.md
Outdated
| and/or measurement accuracy may need to be considered breaking. If in doubt, discuss! | ||
| 5. If things look good, [File an issue](https://github.com/envoyproxy/nighthawk/issues/new?title=[VOTE]+Release+v0.x&body=Release%20X%20is%20ready%20for%20review.%20Please%20take%20a%20look%20and%20vote!) to raise a vote on publishing the drafted release, and point contributors to that. | ||
| 6. Allow sufficient time to transpire for others to provide feedback, before moving on to the next step. If nobody raises blocking issues, it is time to go ahead and publish the drafted release. | ||
| 7. |o/ Announce the new release on Slack, Twitter |
There was a problem hiding this comment.
(optional) Should we include links to the Slack workspace and Twitter?
There was a problem hiding this comment.
Done in 6964102, except Twitter, as there is no official channel.
There was a problem hiding this comment.
(optional) Would it help if we provide a link to some previous tweets?
There was a problem hiding this comment.
That is hard, speaking for myself I didn’t do this for the previous releases yet, but maybe we can copycat Envoy, assuming it does this.. A project account would be nicest IMHO? Not sure how to approach materializing that though.
There was a problem hiding this comment.
Shall we drop Twitter from this document for now and add an issue to track this down? Not sure how much value it provides without the instructions...
There was a problem hiding this comment.
Yeah, makes sense, done and done.
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
mum4k
left a comment
There was a problem hiding this comment.
LGTM, let's wait for this to get unblocked.
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Prerequisite:
version_info.hSigned-off-by: Otto van der Schaaf oschaaf@we-amp.com