Conversation
Update Envoy to 29b30911dbfb3f9760efeb28238ceac36e1a1a23 Brings in the structured versioning API Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
mum4k
left a comment
There was a problem hiding this comment.
Can we hold off this PR for about a day? Eric is trying to import Nighthawk into our internal codebase. We are hoping to import just Nighthawk, not all of Envoy and this PR might break / delay that effort. We should be done with the import by tomorrow end of day.
|
|
||
| Where: | ||
|
|
||
| --disable-extensions <string> |
There was a problem hiding this comment.
Are these changes related to this PR?
There was a problem hiding this comment.
Yeah, this is auto generated and originates from the updated Envoy version which apparently has a new cli arg. As ‘nighthawk_test_server’ basically is Envoy + a static extension we may see this when updating the dependency.
| } | ||
|
|
||
| std::string name() override { return "test-server"; } | ||
| std::string name() const override { return "test-server"; } |
There was a problem hiding this comment.
Similar question here, not sure I follow if this is related to updating Envoy. Do we want a separate PR with description that would explain these additional changes?
Alternatively, please help me understand why they are necessary here.
There was a problem hiding this comment.
Can we hold off this PR for about a day? Eric is trying to import Nighthawk into our internal codebase. We are hoping to import just Nighthawk, not all of Envoy and this PR might break / delay that effort. We should be done with the import by tomorrow end of day.
Sure no problem
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
|
This is now ready to go, we have completed the import internally. Please help by resolving the merge conflict. |
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
|
Done in 23dc8ae |
Update Envoy to 29b30911dbfb3f9760efeb28238ceac36e1a1a23
It is worth noting this upgrades Envoy proto api usage to
v3alphaBrings in the structured versioning API, which we need in #226
Signed-off-by: Otto van der Schaaf oschaaf@we-amp.com