api: update to envoyproxy/envoy@ca7aed4#88
Merged
snowp merged 4 commits intoenvoyproxy:masterfrom Jan 30, 2019
Merged
Conversation
Signed-off-by: Penn (Dapeng) Zhang <zdapeng@google.com>
Signed-off-by: Penn (Dapeng) Zhang <zdapeng@google.com>
Signed-off-by: Penn (Dapeng) Zhang <zdapeng@google.com>
Contributor
|
@dapengzhang0 Can you check CI? |
Contributor
|
I think it's because of the removed |
Contributor
|
@dapengzhang0 Merged in a fix to the CI failure, so if you merge master this should go green. Up to you whether you want to land this before the other Envoy proto update lands or if you want to just do one big update. |
…lane into revert Signed-off-by: dapengzhang0 <zdapeng@google.com>
Contributor
Author
|
Thanks. Let me try to merge this and fix the master build first. |
snowp
approved these changes
Jan 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to envoyproxy/envoy@ca7aed4
This reverts the
option java_multiple_files=trueadded to api proto files, which caused #87.Should be able to fix #87.
The update is done by modifying tools/API_SHAS, then running tools/update-api.sh, and then refactoring.