Add HTTPRoute support for request mirror filters#892
Merged
Xunzhuo merged 5 commits intoenvoyproxy:mainfrom Jan 13, 2023
Alice-Lilith:alicewasko/request-mirror-filter
Merged
Add HTTPRoute support for request mirror filters#892Xunzhuo merged 5 commits intoenvoyproxy:mainfrom Alice-Lilith:alicewasko/request-mirror-filter
Xunzhuo merged 5 commits intoenvoyproxy:mainfrom
Alice-Lilith:alicewasko/request-mirror-filter
Conversation
arkodg
reviewed
Jan 12, 2023
arkodg
reviewed
Jan 12, 2023
Contributor
|
one minor comment, but overall LGTM @AliceProxy ! |
added 5 commits
January 12, 2023 16:28
Signed-off-by: AliceProxy <alicewasko@datawire.io>
Signed-off-by: AliceProxy <alicewasko@datawire.io>
Signed-off-by: AliceProxy <alicewasko@datawire.io>
Signed-off-by: AliceProxy <alicewasko@datawire.io>
Signed-off-by: AliceProxy <alicewasko@datawire.io>
Member
|
I will take a quick review, if nothing is blocking I will merge it. Thanks! |
Xunzhuo
approved these changes
Jan 13, 2023
Member
Xunzhuo
left a comment
There was a problem hiding this comment.
LGTM. Thanks @AliceProxy, don`t forget an end user doc : )
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for request mirror filters for HTTPRoutes.
Resolves #656 but as noted on that issue, the request mirrors will need to be added for gRPCRoutes as well.
if there is anything left that needs to be done for request mirror filters on gRPCRoutes once support for them lands from #805 then I can take that as a separate/follow-up issue.