Gateway API Translator support for GRPCRoute#805
Merged
arkodg merged 10 commits intoenvoyproxy:mainfrom Feb 2, 2023
Merged
Conversation
Contributor
|
Please finish this PR. i think it is an important PR |
554a355 to
5f97834
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #805 +/- ##
==========================================
- Coverage 63.70% 61.80% -1.91%
==========================================
Files 54 54
Lines 7834 8383 +549
==========================================
+ Hits 4991 5181 +190
- Misses 2528 2870 +342
- Partials 315 332 +17
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
added 10 commits
February 1, 2023 17:24
Relates to envoyproxy#642 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
de41848 to
ffa5a5e
Compare
danehans
approved these changes
Feb 2, 2023
| } | ||
| } | ||
|
|
||
| // TODO handle: |
Contributor
There was a problem hiding this comment.
Do we have an issue for this TODO? If not, please create one.
Comment on lines
+404
to
+407
| /* TODO | ||
| if match.Method.Service != nil { | ||
| } | ||
| */ |
Contributor
There was a problem hiding this comment.
Do we have an issue for this TODO? If not, please create one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #642
Signed-off-by: Arko Dasgupta arko@tetrate.io