Adds EnvoyProxy Support to Kubernetes Provider#861
Conversation
Codecov Report
@@ Coverage Diff @@
## main #861 +/- ##
==========================================
+ Coverage 63.91% 64.22% +0.31%
==========================================
Files 50 51 +1
Lines 6506 6616 +110
==========================================
+ Hits 4158 4249 +91
- Misses 2087 2104 +17
- Partials 261 263 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
curious why this function Is needed instead of just capturing the gateway class and the envoy proxy associated with it here
There was a problem hiding this comment.
cc and acceptedGC are created during a reconcile event, e.g. Reconcile(). This method creates the reconcile request for the GC that ref's the watched EnvoyProxy. EnvoyProxy does not bind/ref other resources, e.g. parentRef, so the method must list all GCs to see which one references the watched EnvoyProxy. This is similar to listing all HTTPRoutes for a Gateway CRUD to understand which HTTPRoutes are used to calculate listener conditions.
There was a problem hiding this comment.
Mostly LGTM, but can this be merged after TCPRoute Implementation get merged? Or there will be more conflicts I need to resolve.
2e42dcd to
6d2e274
Compare
|
@arkodg I commented/resolved your review feedback, PTAL. |
6d2e274 to
9a5273f
Compare
Signed-off-by: danehans <daneyonhansen@gmail.com>
9a5273f to
f4e288c
Compare
Adds EnvoyProxy support to the Kubernetes provider.
Signed-off-by: danehans daneyonhansen@gmail.com