Skip to content

feat: add support for TCP Route#737

Merged
arkodg merged 1 commit intoenvoyproxy:mainfrom
Xunzhuo:feat-tcp-route
Jan 6, 2023
Merged

feat: add support for TCP Route#737
arkodg merged 1 commit intoenvoyproxy:mainfrom
Xunzhuo:feat-tcp-route

Conversation

@Xunzhuo
Copy link
Copy Markdown
Member

@Xunzhuo Xunzhuo commented Nov 17, 2022 •
edited
Loading

Resolves: #643

Progress:

  • Xds IR
  • Xds Translator
  • Gateway API Translator
  • Provider
  • Docs

Signed-off-by: bitliu bitliu@tencent.com

@Xunzhuo Xunzhuo force-pushed the feat-tcp-route branch 2 times, most recently from 69b3873 to d3f5f14 Compare November 17, 2022 18:36
@danehans
Copy link
Copy Markdown
Contributor

danehans commented Dec 5, 2022

@Xunzhuo are you able to complete this PR and the additional work to add TCPRoute support for v0.3.0-rc.1?

@Xunzhuo
Copy link
Copy Markdown
Member Author

Xunzhuo commented Dec 6, 2022

Yes, it could be done possibly, I am quite busy this week, will come back to feature implementations this weekend.

@Xunzhuo Xunzhuo added area/api API-related issues area/translator Issues related to Gateway's translation service, e.g. translating Gateway APIs into the IR. area/conformance Gateway API Conformance Related Issues labels Dec 6, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 3, 2023 •
edited by codecov bot
Loading

Codecov Report

❌ Patch coverage is 51.01289% with 266 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.66%. Comparing base (309566d) to head (fafa4aa).
⚠️ Report is 3648 commits behind head on main.

Files with missing lines Patch % Lines
internal/provider/kubernetes/controller.go 34.74% 136 Missing and 33 partials ⚠️
internal/provider/kubernetes/routes.go 11.90% 35 Missing and 2 partials ⚠️
internal/gatewayapi/contexts.go 69.64% 14 Missing and 3 partials ⚠️
internal/xds/translator/translator.go 43.47% 10 Missing and 3 partials ⚠️
internal/gatewayapi/route.go 87.87% 9 Missing and 3 partials ⚠️
internal/gatewayapi/zz_generated.deepcopy.go 0.00% 9 Missing ⚠️
internal/gatewayapi/runner/runner.go 0.00% 4 Missing ⚠️
internal/provider/kubernetes/predicates.go 50.00% 3 Missing and 1 partial ⚠️
internal/message/types.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #737      +/-   ##
==========================================
- Coverage   64.06%   63.66%   -0.40%     
==========================================
  Files          50       50              
  Lines        6486     6815     +329     
==========================================
+ Hits         4155     4339     +184     
- Misses       2075     2200     +125     
- Partials      256      276      +20

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Xunzhuo Xunzhuo changed the title feat: add support for TCP Route feat(Gateway API Translator): add support for TCP Route Jan 3, 2023
@Xunzhuo Xunzhuo changed the title feat(Gateway API Translator): add support for TCP Route feat: add support for TCP Route Jan 3, 2023
@Xunzhuo Xunzhuo force-pushed the feat-tcp-route branch 2 times, most recently from 82f300d to 038e628 Compare January 3, 2023 04:10
@Xunzhuo Xunzhuo added the priority/high Label used to express the "high" priority level label Jan 3, 2023
@Xunzhuo Xunzhuo force-pushed the feat-tcp-route branch 6 times, most recently from ab54500 to 20d7de5 Compare January 3, 2023 07:28
@Xunzhuo Xunzhuo added this to the 0.3.0-rc.1 milestone Jan 3, 2023
@Xunzhuo Xunzhuo marked this pull request as ready for review January 3, 2023 07:29
@Xunzhuo Xunzhuo requested a review from a team as a code owner January 3, 2023 07:29
@Xunzhuo Xunzhuo force-pushed the feat-tcp-route branch 3 times, most recently from 98843ab to c1deb92 Compare January 3, 2023 10:39
arkodg
arkodg reviewed Jan 3, 2023
View reviewed changes
docs/latest/user/tcp-routing.md Outdated
Copy link
Copy Markdown
Contributor

@arkodg arkodg Jan 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you expand a little more for this example

Copy link
Copy Markdown
Member Author

@Xunzhuo Xunzhuo Jan 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we expand this with an additional docs PR?

Copy link
Copy Markdown
Contributor

@arkodg arkodg Jan 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure np

arkodg
arkodg reviewed Jan 3, 2023
View reviewed changes
arkodg
arkodg reviewed Jan 3, 2023
View reviewed changes
arkodg
arkodg reviewed Jan 3, 2023
View reviewed changes
zirain
zirain reviewed Jan 4, 2023
View reviewed changes
zirain
zirain reviewed Jan 4, 2023
View reviewed changes
@Xunzhuo
feat: add support for TCP Route
fafa4aa 
Signed-off-by: bitliu <bitliu@tencent.com>
arkodg
arkodg approved these changes Jan 6, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding this feature in @Xunzhuo 🚀 !

@arkodg arkodg merged commit 9c1645a into envoyproxy:main Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zirain zirain zirain left review comments

@arkodg arkodg arkodg approved these changes

Assignees

No one assigned

Labels

area/api API-related issues area/conformance Gateway API Conformance Related Issues area/translator Issues related to Gateway's translation service, e.g. translating Gateway APIs into the IR. priority/high Label used to express the "high" priority level

Projects

None yet

Milestone

0.3.0-rc.1

Development

Successfully merging this pull request may close these issues.

Add Support for TCPRoute API

5 participants

@Xunzhuo @danehans @codecov-commenter @zirain @arkodg