Merged
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 canceled.
|
arkodg
approved these changes
Mar 8, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8448 +/- ##
==========================================
- Coverage 74.17% 74.12% -0.05%
==========================================
Files 242 242
Lines 37579 37579
==========================================
- Hits 27875 27857 -18
- Misses 7762 7781 +19
+ Partials 1942 1941 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zirain
approved these changes
Mar 8, 2026
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
d41e2c9 to
73f4cc8
Compare
zhaohuabing
approved these changes
Mar 9, 2026
Member
zhaohuabing
left a comment
There was a problem hiding this comment.
Nice catch! Thanks for fixing it!
rudrakhp
approved these changes
Mar 9, 2026
rudrakhp
pushed a commit
to rudrakhp/gateway
that referenced
this pull request
Mar 12, 2026
fix multiple gc e2e Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
rudrakhp
pushed a commit
to rudrakhp/gateway
that referenced
this pull request
Mar 12, 2026
fix multiple gc e2e Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
rudrakhp
added a commit
that referenced
this pull request
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix: multiple gc e2e
What this PR does / why we need it:
Currently, TestMultipleGC is flaky.
this flakiness root cause is that same name resource create/delete in parallel.
TestMultipleGC (Internet GC/Private GC) does in parallel.
https://github.com/envoyproxy/gateway/blob/main/test/e2e/multiple_gc/multiple_gc_test.go#L44
and, some test cases, they has same name resource.
so, if one test case does clean up while the other test case does setup, the other test case fails.
Which issue(s) this PR fixes:
Fixes #8442
Release Notes: No