Merged
Conversation
Signed-off-by: zirain <zirain2009@gmail.com>
✅ Deploy Preview for cerulean-figolla-1f9435 canceled.
|
zirain
commented
Feb 24, 2026
test/go.mod
Outdated
| sigs.k8s.io/controller-runtime v0.23.1 | ||
| sigs.k8s.io/gateway-api v1.5.0-rc.1 | ||
| sigs.k8s.io/gateway-api/conformance v0.0.0-20260213022600-e0bee71fc23d | ||
| sigs.k8s.io/gateway-api/conformance v0.0.0-20260224135735-8f1414bedc59 |
Member
Author
There was a problem hiding this comment.
xref: kubernetes-sigs/gateway-api#4540
will be removed when bumping to v1.5.0
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8335 +/- ##
==========================================
- Coverage 73.87% 73.86% -0.02%
==========================================
Files 242 242
Lines 37044 37044
==========================================
- Hits 27368 27362 -6
- Misses 7745 7752 +7
+ Partials 1931 1930 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jukie
previously approved these changes
Feb 24, 2026
cnvergence
previously approved these changes
Feb 24, 2026
Member
cnvergence
left a comment
There was a problem hiding this comment.
Great, I'm happy that you have added it :)
Signed-off-by: zirain <zirain2009@gmail.com>
cnvergence
approved these changes
Feb 25, 2026
kkk777-7
approved these changes
Feb 25, 2026
Member
|
LGTM, thanks! |
Member
|
/retest |
Member
Author
|
/retest |
antonio-mazzini
pushed a commit
to antonio-mazzini/gateway
that referenced
this pull request
Mar 5, 2026
* chore: adopt FailFast Signed-off-by: zirain <zirain2009@gmail.com> * fix lint Signed-off-by: zirain <zirain2009@gmail.com> * skip GatewayFrontendClientCertificateValidationInsecureFallback Signed-off-by: zirain <zirain2009@gmail.com> --------- Signed-off-by: zirain <zirain2009@gmail.com> Co-authored-by: Karol Szwaj <karol.szwaj@gmail.com> Co-authored-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #8098