Merged
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 canceled.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8187 +/- ##
==========================================
- Coverage 73.85% 73.84% -0.02%
==========================================
Files 242 242
Lines 37044 37050 +6
==========================================
Hits 27358 27358
- Misses 7753 7759 +6
Partials 1933 1933 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
82facb9 to
5d39f4b
Compare
jukie
reviewed
Feb 7, 2026
arkodg
reviewed
Feb 8, 2026
ad7262c to
15a9479
Compare
15a9479 to
6ef431e
Compare
This was referenced Feb 26, 2026
e31dd35 to
6196aa9
Compare
arkodg
reviewed
Feb 28, 2026
arkodg
reviewed
Feb 28, 2026
|
|
||
| var hasHostnameIntersection bool | ||
| // need to check hostname intersection if there are listeners | ||
| hasHostnameIntersection := len(parentRef.listeners) == 0 |
Contributor
There was a problem hiding this comment.
how does this help, computeHosts resets this anyways
Member
Author
There was a problem hiding this comment.
if there're any listeners, the logic is same as before.
this's used to avoid hasHostnameIntersection to false when there's no valid listener.
Contributor
There was a problem hiding this comment.
its already defaulting to false since its a bool
Member
Author
There was a problem hiding this comment.
yes, but when there's no valid listener, we want true to avoid incorrect hostname intersection check.
arko-oai
approved these changes
Feb 28, 2026
arkodg
approved these changes
Feb 28, 2026
jukie
approved these changes
Feb 28, 2026
antonio-mazzini
pushed a commit
to antonio-mazzini/gateway
that referenced
this pull request
Mar 5, 2026
* commit testdata Signed-off-by: zirain <zirain2009@gmail.com> * update Signed-off-by: zirain <zirain2009@gmail.com> * fix gen Signed-off-by: zirain <zirain2009@gmail.com> --------- Signed-off-by: zirain <zirain2009@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xref: #8244
Find this during test TLSRoute conformance test TLSRouteInvalidNoMatchingListenerHostname.
The issue is that, if a route is invalid(e.g. hostname no matching),
attachedRoutesshouldn't be increased.