Skip to content

feat: Implement RoutingType BTP#8173

Merged
jukie merged 21 commits intoenvoyproxy:mainfrom
jukie:feat-routing-type-btp
Feb 28, 2026
Merged

feat: Implement RoutingType BTP#8173
jukie merged 21 commits intoenvoyproxy:mainfrom
jukie:feat-routing-type-btp

Conversation

@jukie
Copy link
Copy Markdown
Contributor

@jukie jukie commented Feb 4, 2026 •
edited
Loading

What this PR does / why we need it:
Adds implementation for BTP-level RoutingType field

Which issue(s) this PR fixes:

Fixes #7926

Release Notes: Yes

@netlify
Copy link
Copy Markdown

netlify bot commented Feb 4, 2026 •
edited
Loading

❌ Deploy Preview for cerulean-figolla-1f9435 failed.

Name Link
🔨 Latest commit 9c3238d
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/69a2fbec5e9de70008ee6cea

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 4, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 97.58065% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.95%. Comparing base (bf0f05b) to head (9c3238d).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/gatewayapi/backendtrafficpolicy.go 97.05% 1 Missing and 1 partial ⚠️
internal/gatewayapi/ext_service.go 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8173      +/-   ##
==========================================
+ Coverage   73.85%   73.95%   +0.10%     
==========================================
  Files         242      242              
  Lines       37061    37158      +97     
==========================================
+ Hits        27372    27482     +110     
+ Misses       7761     7745      -16     
- Partials     1928     1931       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jukie jukie marked this pull request as ready for review February 4, 2026 02:55
@jukie jukie requested a review from a team as a code owner February 4, 2026 02:55
@jukie jukie changed the title Implement RoutingType BTP feat: Implement RoutingType BTP Feb 4, 2026
@jukie
Copy link
Copy Markdown
Contributor Author

jukie commented Feb 4, 2026

/retest

@jukie jukie requested review from a team and nareddyt February 4, 2026 04:06
@jukie
Copy link
Copy Markdown
Contributor Author

jukie commented Feb 6, 2026

/retest

1 similar comment
@jukie
Copy link
Copy Markdown
Contributor Author

jukie commented Feb 7, 2026

/retest

arkodg
arkodg reviewed Feb 8, 2026
View reviewed changes
@jukie
Copy link
Copy Markdown
Contributor Author

jukie commented Feb 8, 2026

/retest

@jukie jukie requested review from a team and arkodg February 9, 2026 18:46
@jukie
Copy link
Copy Markdown
Contributor Author

jukie commented Feb 16, 2026

/retest

jukie and others added 2 commits February 19, 2026 08:52
@jukie
Implement RoutingType BTP
6c8ac38 
Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>
@jukie
notes
7824143 
Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>
nareddyt
nareddyt approved these changes Feb 19, 2026
View reviewed changes
internal/gatewayapi/backendtrafficpolicy.go Outdated
}
}

// Check targetSelectors (label-based targeting)
Copy link
Copy Markdown
Contributor

@nareddyt nareddyt Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with targetSelectors, but can they target specific route rules or specific listeners in a gateway?

Copy link
Copy Markdown
Contributor Author

@jukie jukie Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No they can't target specific rules, it's just a label selector for Kubernetes resources + group/kind matching.

jukie and others added 3 commits February 19, 2026 09:07
@jukie
Support all BTP targeting scenarios
a75379b 
Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>
@jukie
gen-check
b72cbae 
Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>
@jukie
Tweak EP routingtype check
f991418 
Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>
@jukie jukie force-pushed the feat-routing-type-btp branch from f177014 to f991418 Compare February 19, 2026 16:13
@jukie jukie added this to the v1.8.0-rc.1 Release milestone Feb 19, 2026
@zirain
Copy link
Copy Markdown
Member

zirain commented Feb 24, 2026

/retest

@jukie
Improve lookup perf
288fa76 
Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>
@jukie jukie force-pushed the feat-routing-type-btp branch from 3209584 to 288fa76 Compare February 25, 2026 00:48
@jukie
Copy link
Copy Markdown
Contributor Author

jukie commented Feb 26, 2026

/retest

1 similar comment
@jukie
Copy link
Copy Markdown
Contributor Author

jukie commented Feb 26, 2026

/retest

jukie and others added 4 commits February 26, 2026 10:41
@jukie
Merge branch 'main' into feat-routing-type-btp
f312ed1
@jukie
Merge branch 'main' into feat-routing-type-btp
f259056
@jukie
Adjust logic
ac7f1e8 
Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>
@jukie
format
3691a0f 
Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>
@zirain
Copy link
Copy Markdown
Member

zirain commented Feb 28, 2026

it would be better to see some e2e tests happen in the future.

@jukie jukie requested review from a team and nareddyt February 28, 2026 04:42
@jukie
Copy link
Copy Markdown
Contributor Author

jukie commented Feb 28, 2026 •
edited
Loading

Do you have something in mind for an e2e? Traffic still ends up hitting the same backends so I wasn't sure how to improve validation besides adding exhaustive testdata renders.

@kkk777-7
Copy link
Copy Markdown
Member

kkk777-7 commented Feb 28, 2026

LGTM, thanks!

@kkk777-7
Copy link
Copy Markdown
Member

kkk777-7 commented Feb 28, 2026

/retest

2 similar comments
@jukie
Copy link
Copy Markdown
Contributor Author

jukie commented Feb 28, 2026

/retest

@jukie
Copy link
Copy Markdown
Contributor Author

jukie commented Feb 28, 2026

/retest

@jukie jukie merged commit ae25790 into envoyproxy:main Feb 28, 2026
135 of 154 checks passed
@jukie jukie deleted the feat-routing-type-btp branch February 28, 2026 18:41
antonio-mazzini pushed a commit to antonio-mazzini/gateway that referenced this pull request Mar 5, 2026
@jukie
feat: Implement RoutingType BTP (envoyproxy#8173)
c187cde 
* Implement RoutingType BTP

Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>

* notes

Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>

* Support all BTP targeting scenarios

Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>

* gen-check

Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>

* Tweak EP routingtype check

Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>

* gen-check

Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>

* Improve lookup perf

Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>

* fix

Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>

* Adjust logic

Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>

* format

Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>

---------

Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>
Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zirain zirain zirain approved these changes

@kkk777-7 kkk777-7 kkk777-7 approved these changes

@arkodg arkodg Awaiting requested review from arkodg

@nareddyt nareddyt Awaiting requested review from nareddyt

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.8.0-rc.1 Release

Development

Successfully merging this pull request may close these issues.

Allow setting RoutingType on a per-route level

5 participants

@jukie @zirain @kkk777-7 @arkodg @nareddyt