Skip to content

fix EnvoyProxyTemplate test#8118

Merged
zirain merged 2 commits intoenvoyproxy:mainfrom
zirain:fix/EnvoyProxyTemplate
Jan 29, 2026
Merged

fix EnvoyProxyTemplate test#8118
zirain merged 2 commits intoenvoyproxy:mainfrom
zirain:fix/EnvoyProxyTemplate

Conversation

@zirain
Copy link
Copy Markdown
Member

@zirain zirain commented Jan 29, 2026

The root cause is that envoy-gateway GatewayClass is delete when terminating HTTPRouteDualStack test.

@zirain
fix EnvoyProxyTemplate test
16579f7 
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain requested a review from a team as a code owner January 29, 2026 05:35
@netlify
Copy link
Copy Markdown

netlify bot commented Jan 29, 2026 •
edited
Loading

✅ Deploy Preview for cerulean-figolla-1f9435 canceled.

Name Link
🔨 Latest commit 2544cc3
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/697af1c8a9c7bf000897f067

@zirain
revert
2544cc3 
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain mentioned this pull request Jan 29, 2026
Closed
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 29, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.67%. Comparing base (ea1a322) to head (2544cc3).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8118      +/-   ##
==========================================
- Coverage   73.68%   73.67%   -0.01%     
==========================================
  Files         239      239              
  Lines       36311    36311              
==========================================
- Hits        26754    26751       -3     
- Misses       7664     7666       +2     
- Partials     1893     1894       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zirain
Copy link
Copy Markdown
Member Author

zirain commented Jan 29, 2026

/retest

@zirain zirain merged commit c9e3d5f into envoyproxy:main Jan 29, 2026
78 of 82 checks passed
@zirain zirain deleted the fix/EnvoyProxyTemplate branch January 29, 2026 08:39
@arkodg
Copy link
Copy Markdown
Contributor

arkodg commented Jan 30, 2026

@zirain can you elaborate on the issue

@zirain
Copy link
Copy Markdown
Member Author

zirain commented Jan 30, 2026 •
edited
Loading

@zirain can you elaborate on the issue

the HTTPRouteDualStack case cause envoy-gateway GatewayClass deleted when terminating.

A gatewayclass will be skipped if it's marked as deleted. In the end, it will fallback to use the default EnvoyProxy in EnvoyGateway, which cause infra provision failed.

gateway/internal/provider/kubernetes/controller.go

Line 351 in b6033c2

if managedGC.Spec.ParametersRef != nil && managedGC.DeletionTimestamp == nil {

SadmiB pushed a commit to SadmiB/gateway that referenced this pull request Jan 30, 2026
@zirain @SadmiB
fix EnvoyProxyTemplate test (envoyproxy#8118)
3f598f2 
* fix EnvoyProxyTemplate test

Signed-off-by: zirain <zirain2009@gmail.com>

* revert

Signed-off-by: zirain <zirain2009@gmail.com>

---------

Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: Sadmi Bouhafs <sadmibouhafs@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhaohuabing zhaohuabing zhaohuabing approved these changes

@cnvergence cnvergence cnvergence approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zirain @arkodg @zhaohuabing @cnvergence