[docs] fix docs for XDSNameSchemeV2 defaults#8043
[docs] fix docs for XDSNameSchemeV2 defaults#8043zhaohuabing merged 1 commit intoenvoyproxy:mainfrom
Conversation
Relates to envoyproxy#6865 (comment) Signed-off-by: Arko Dasgupta <arkodg@gmail.com>
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR updates documentation about when the XDSNameSchemeV2 runtime flag will be enabled by default. The changes update references from v1.6 to v1.10 as the version where the flag will be enabled by default.
Changes:
- Updated documentation in v1.6 extensibility guide to indicate XDSNameSchemeV2 will be enabled by default in v1.10 (changed from v1.6)
- Updated v1.5.0 release notes to reflect the same v1.10 timeline (changed from v1.6)
- Removed a trailing empty line in v1.5.0 release notes
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| site/content/en/v1.6/tasks/extensibility/envoy-patch-policy.md | Updates two references from v1.6 to v1.10 for when XDSNameSchemeV2 will be enabled by default and when users should migrate |
| site/content/en/news/releases/notes/v1.5.0.md | Updates reference from v1.6 to v1.10 in breaking changes section and removes trailing empty line |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
|
|
||
| This change is gated by the XDSNameSchemeV2 runtime flag. The flag is disabled by default in v1.5 and will be enabled by default starting in v1.6. | ||
| This change is gated by the XDSNameSchemeV2 runtime flag. The flag is disabled by default in v1.5 and will be enabled by default starting in v1.10. |
There was a problem hiding this comment.
There is a discrepancy between this documentation change and the referenced issue #6865. The issue states "We need to flip on the XDSNameSchemeV2 runtime flag in v1.7.0", but this PR changes the documentation to indicate the flag will be enabled by default starting in v1.10. Please verify which version is correct. If v1.7.0 is the intended version, this should be changed to v1.7. If v1.10 is correct, the issue description should be updated to reflect that.
zhaohuabing
left a comment
There was a problem hiding this comment.
Glad you still remember updating this :-)
Relates to envoyproxy#6865 (comment) Signed-off-by: Arko Dasgupta <arkodg@gmail.com> Signed-off-by: Sadmi Bouhafs <sadmibouhafs@gmail.com>
Relates to #6865 (comment)