is this needed ?

This part is supposed to check for a single stack

   
	if service.Spec.ClusterIP == "None" || service.Spec.ClusterIP == "" {
		return true
	}

And this part is for dual stack

	if len(service.Spec.ClusterIPs) > 0 {
		for _, ip := range service.Spec.ClusterIPs {
			if ip != "None" && ip != "" {
				return false
			}
		}
		return true
	}

However, in practice, I am unsure if a case like THIS TESTCASE is even possible, where the service is dual-stack headless (ClusterIPs: []string{"None", "None"}) but ClusterIP is set. I guess not.

In that case, I guess we can remove the part where I am iterating over service.Spec.ClusterIPs list. Let me know your thoughts.

can you cross check, if that test case is NA, we should just rm it and the logic to avoid designing around this in the future

Just checked; that testcase is not possible in practice. I tried to create the following service, and it's rejected by Kubernetes API server validation. Updated the code now

apiVersion: v1
kind: Service
metadata:
  name: headless-service
spec:
  clusterIP: None
  clusterIPs:
    - 10.96.0.100
    - fd00:10:96::100
  ipFamilies:
    - IPv4
    - IPv6
  ipFamilyPolicy: RequireDualStack   # add this
  selector:
    app: headless-backend
  ports:
    - port: 80