fix: rbac for namespaceSelector in Gateway Namespace Mode#8014
Merged
zirain merged 3 commits intoenvoyproxy:mainfrom Jan 28, 2026
Merged
fix: rbac for namespaceSelector in Gateway Namespace Mode#8014zirain merged 3 commits intoenvoyproxy:mainfrom
zirain merged 3 commits intoenvoyproxy:mainfrom
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 canceled.
|
Member
Author
|
This PR currently sets a ClusterRole with Helm, if namespaceSelector is set with GatewayNamespace mode. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8014 +/- ##
==========================================
- Coverage 73.80% 73.77% -0.03%
==========================================
Files 237 237
Lines 35753 35753
==========================================
- Hits 26386 26376 -10
- Misses 7512 7520 +8
- Partials 1855 1857 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
576d57f to
c475603
Compare
Member
|
is this a fix or a feature, do we need to backport this? |
arkodg
previously approved these changes
Jan 24, 2026
44098cd to
adbc420
Compare
kkk777-7
previously approved these changes
Jan 25, 2026
Contributor
|
gateway-namespace-mode tests seems to consistenly fail |
Member
Author
|
/retest |
1 similar comment
Member
Author
|
/retest |
b596bf5 to
177294f
Compare
6c574aa to
788aeb4
Compare
zirain
previously approved these changes
Jan 27, 2026
zhaohuabing
reviewed
Jan 27, 2026
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
788aeb4 to
92ae167
Compare
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
Member
|
/retest |
zirain
approved these changes
Jan 28, 2026
zhaohuabing
approved these changes
Jan 28, 2026
SadmiB
pushed a commit
to SadmiB/gateway
that referenced
this pull request
Jan 30, 2026
…#8014) * fix: rbac for namespaceSelector in Gateway Namespace Mode Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> * double check the conditional logic Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> * readd the comment in the helm template Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> --------- Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> Signed-off-by: Sadmi Bouhafs <sadmibouhafs@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
This PR adds cluster roles when namespace selector is used with namespace watch.
Which issue(s) this PR fixes:
Fixes #7617
Release Notes: Yes/No