Skip to content

chore: use Patch instead of Update in e2e#8012

Merged
zirain merged 5 commits intoenvoyproxy:mainfrom
zirain:use-patch
Jan 25, 2026
Merged

chore: use Patch instead of Update in e2e#8012
zirain merged 5 commits intoenvoyproxy:mainfrom
zirain:use-patch

Conversation

@zirain
Copy link
Copy Markdown
Member

@zirain zirain commented Jan 21, 2026

2026-01-21T06:36:25.8737660Z     proxy_protocol.go:53: 
2026-01-21T06:36:25.8738928Z         	Error Trace:	/home/runner/work/gateway/gateway/test/e2e/tests/proxy_protocol.go:53
2026-01-21T06:36:25.8741792Z         	            				/home/runner/go/pkg/mod/sigs.k8s.io/gateway-api@v1.4.1/conformance/utils/suite/conformance.go:77
2026-01-21T06:36:25.8744287Z         	            				/home/runner/go/pkg/mod/sigs.k8s.io/gateway-api@v1.4.1/conformance/utils/suite/suite.go:487
2026-01-21T06:36:25.8745573Z         	Error:      	Received unexpected error:
2026-01-21T06:36:25.8748987Z         	            	Operation cannot be fulfilled on backends.gateway.envoyproxy.io "proxy-protocol-backend": the object has been modified; please apply your changes to the latest version and try again
2026-01-21T06:36:25.8762876Z         	Test:       	TestE2E/ProxyProtocol

@zirain zirain requested a review from a team as a code owner January 21, 2026 07:13
@netlify
Copy link
Copy Markdown

netlify bot commented Jan 21, 2026

Deploy Preview for cerulean-figolla-1f9435 canceled.

Name Link
🔨 Latest commit ec17bc1
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/6971d23ef63e630008c1026a

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.84%. Comparing base (b8d986c) to head (ec17bc1).
⚠️ Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8012      +/-   ##
==========================================
+ Coverage   72.81%   72.84%   +0.02%     
==========================================
  Files         237      237              
  Lines       35623    35623              
==========================================
+ Hits        25938    25948      +10     
+ Misses       7834     7828       -6     
+ Partials     1851     1847       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: zirain <zirain2009@gmail.com>
cnvergence
cnvergence previously approved these changes Jan 21, 2026
kkk777-7
kkk777-7 previously approved these changes Jan 21, 2026
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain dismissed stale reviews from kkk777-7 and cnvergence via 5fed8e3 January 22, 2026 01:31
Signed-off-by: zirain <zirain2009@gmail.com>
arkodg
arkodg previously approved these changes Jan 22, 2026
@zirain
Copy link
Copy Markdown
Member Author

zirain commented Jan 22, 2026

another flaky in https://github.com/envoyproxy/gateway/actions/runs/21234888171/job/61104808409?pr=8012:

roundtripper.go:234: 2026-01-22T05:06:13.215740253Z: Sending Request:
        < GET / HTTP/1.1
        < Host: 172.18.0.205
        < User-Agent: Go-http-client/1.1
        < X-Echo-Set-Header: 
        < Accept-Encoding: gzip
        < 
        < 
        
        
    roundtripper.go:262: 2026-01-22T05:06:15.289475007Z: Received Response:
        < HTTP/1.1 503 Service Unavailable
        < Connection: close
        < Content-Length: 19
        < Content-Type: text/plain
        < Date: Thu, 22 Jan 2026 05:06:14 GMT
        < 
        < no healthy upstream
        
        
    http.go:276: 2026-01-22T05:06:15.289582578Z: Response expectation failed for request: {URL: {Scheme:http Opaque: User: Host:172.18.0.205 Path:/ RawPath: OmitHost:false ForceQuery:false RawQuery: Fragment: RawFragment:}, Host: , Protocol: HTTP, Method: GET, Headers: map[X-Echo-Set-Header:[]], UnfollowRedirect: false, Server: , CertPem: <truncated>, KeyPem: <truncated>}  not ready yet: expected status code to be one of [200], got 503. CRes: &{503 19 HTTP/1.1 map[Content-Length:[19] Content-Type:[text/plain] Date:[Thu, 22 Jan 2026 05:06:14 GMT]] <nil> []} (after 18.447789989s)

Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain merged commit ced5d75 into envoyproxy:main Jan 25, 2026
57 of 59 checks passed
@zirain zirain deleted the use-patch branch January 25, 2026 03:58
SadmiB pushed a commit to SadmiB/gateway that referenced this pull request Jan 30, 2026
* use patch

Signed-off-by: zirain <zirain2009@gmail.com>

* use apply

Signed-off-by: zirain <zirain2009@gmail.com>

* fix

Signed-off-by: zirain <zirain2009@gmail.com>

* fix

Signed-off-by: zirain <zirain2009@gmail.com>

* fix lint

Signed-off-by: zirain <zirain2009@gmail.com>

---------

Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: Sadmi Bouhafs <sadmibouhafs@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants