Skip to content

feat: allow updating initial_fetch_timeout in bootstrap#7962

Merged
arkodg merged 5 commits intoenvoyproxy:mainfrom
andreik-n2:main
Jan 25, 2026
Merged

feat: allow updating initial_fetch_timeout in bootstrap#7962
arkodg merged 5 commits intoenvoyproxy:mainfrom
andreik-n2:main

Conversation

@andreik-n2
Copy link
Copy Markdown
Contributor

@andreik-n2 andreik-n2 commented Jan 15, 2026 •
edited
Loading

What type of PR is this?

fix: ignore initial_fetch_timeout in bootstrap validation to allow modifying this parameter. Set initial_fetch_timeout to 0s by default.

What this PR does / why we need it: This PR updates the bootstrap validation logic to ignore the initial_fetch_timeout field within cds_config and lds_config during comparison. Also this PR sets default initial_fetch_timeout to 0s in the bootstrap config.

Which issue(s) this PR fixes:

Fixes #5574
Release Notes: Yes

@andreik-n2
feat: allow updating initial_fetch_timeout in bootstrap
f4489f6 
Signed-off-by: andrei <andrei@n2.games>
@andreik-n2 andreik-n2 requested a review from a team as a code owner January 15, 2026 07:37
@netlify
Copy link
Copy Markdown

netlify bot commented Jan 15, 2026 •
edited
Loading

✅ Deploy Preview for cerulean-figolla-1f9435 canceled.

Name Link
🔨 Latest commit 7d4ba20
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/69759931f655c30008fa1aef

@andreik-n2 andreik-n2 mentioned this pull request Jan 15, 2026
Closed
@zirain
Copy link
Copy Markdown
Member

zirain commented Jan 15, 2026

please add a release notes.

@zirain
Copy link
Copy Markdown
Member

zirain commented Jan 15, 2026

@andreik-n2 please fix the conflict.

@andreik-n2
Merge branch 'main' into main
860c638 
Signed-off-by: andreik-n2 <144345749+andreik-n2@users.noreply.github.com>
@arkodg
Copy link
Copy Markdown
Contributor

arkodg commented Jan 16, 2026

@andreik-n2 can we default to 0 ?

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 16, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.71%. Comparing base (ced5d75) to head (7d4ba20).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7962      +/-   ##
==========================================
+ Coverage   73.69%   73.71%   +0.02%     
==========================================
  Files         237      237              
  Lines       35653    35654       +1     
==========================================
+ Hits        26274    26282       +8     
+ Misses       7520     7515       -5     
+ Partials     1859     1857       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zirain
Copy link
Copy Markdown
Member

zirain commented Jan 16, 2026 •
edited
Loading

@andreik-n2 can we default to 0 ?

I don't think this PR change the default value from 15s to 0s, it make it patched.
do you want to introduce a change?

zirain
zirain reviewed Jan 16, 2026
View reviewed changes
@andreik-n2
Copy link
Copy Markdown
Contributor Author

andreik-n2 commented Jan 16, 2026 •
edited
Loading

@andreik-n2 can we default to 0 ?

Hi @arkodg , are you sure you want set default to 0? I read that it could lead to having envoy proxy in not ready state indefinitely. Is it something you considered?

@arkodg
Copy link
Copy Markdown
Contributor

arkodg commented Jan 17, 2026

@andreik-n2 can we default to 0 ?

Hi @arkodg , are you sure you want set default to 0? I read that it could lead to having envoy proxy in not ready state indefinitely. Is it something you considered?

yeah its better to fail hard for this case that configure partial config

@arkodg
Copy link
Copy Markdown
Contributor

arkodg commented Jan 17, 2026

ptal @envoyproxy/gateway-maintainers

@arkodg arkodg added this to the v1.7.0-rc.1 Release milestone Jan 17, 2026
@andreik-n2
feat: add default initial_fetch_timeout = 0s to xDS bootstrap confi…
8e7dd07 
…guration.

Signed-off-by: andrei <andrei@n2.games>
arkodg
arkodg reviewed Jan 19, 2026
View reviewed changes
arkodg
arkodg approved these changes Jan 24, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@arkodg arkodg requested review from a team January 24, 2026 19:16
@arkodg arkodg merged commit afdb449 into envoyproxy:main Jan 25, 2026
56 of 62 checks passed
@zirain zirain mentioned this pull request Jan 27, 2026
Merged
SadmiB pushed a commit to SadmiB/gateway that referenced this pull request Jan 30, 2026
@andreik-n2 @SadmiB
feat: allow updating initial_fetch_timeout in bootstrap (envoyproxy#7962
9f9db38 
)

* feat: add default `initial_fetch_timeout` = 0s to xDS bootstrap configuration.

Signed-off-by: andrei <andrei@n2.games>
Signed-off-by: Sadmi Bouhafs <sadmibouhafs@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zirain zirain zirain approved these changes

@arkodg arkodg arkodg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.7.0-rc.1 Release

Development

Successfully merging this pull request may close these issues.

Determine xDS initial_fetch_timeout value

3 participants

@andreik-n2 @zirain @arkodg