fix: validation behavior for multiple certificate refs#7909
Merged
arkodg merged 5 commits intoenvoyproxy:mainfrom Jan 14, 2026
Merged
fix: validation behavior for multiple certificate refs#7909arkodg merged 5 commits intoenvoyproxy:mainfrom
arkodg merged 5 commits intoenvoyproxy:mainfrom
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7909 +/- ##
=======================================
Coverage 72.79% 72.79%
=======================================
Files 235 235
Lines 35214 35295 +81
=======================================
+ Hits 25635 25694 +59
- Misses 7760 7778 +18
- Partials 1819 1823 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kkk777-7
commented
Jan 10, 2026
| // with a Reason method that returns the specific condition reason. | ||
| // | ||
| // TODO kkk777-7: consider using generics to make Error interface resource-agnostic to support all resource types. | ||
| type ListenerError interface { |
Member
Author
There was a problem hiding this comment.
I think we should use generics in error interface to avoid duplication.
But this needs wide changes. so I want to handle this in follow up PR.
This was referenced Jan 10, 2026
Closed
arkodg
reviewed
Jan 10, 2026
arkodg
reviewed
Jan 10, 2026
Member
Author
|
gentle ping @zhaohuabing |
9a5cbde to
f3cc480
Compare
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
f3cc480 to
503a781
Compare
zirain
approved these changes
Jan 14, 2026
andreik-n2
pushed a commit
to andreik-n2/gateway
that referenced
this pull request
Jan 15, 2026
* fix: multiple certificates validation behavior Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
SadmiB
pushed a commit
to SadmiB/gateway
that referenced
this pull request
Jan 30, 2026
* fix: multiple certificates validation behavior Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> Signed-off-by: Sadmi Bouhafs <sadmibouhafs@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fix validation behavior for multiple certificate refs.
currently, when both an invalid certificate ref and a valid certificate ref are present in listener TLS, we set
ResolvedRefs=FalseandProgrammed=False.As a result, listener translation fails and no xDS listeners are generated.
we update the behavior by introducing new
PartiallyInvalidCertificateRefcondition reason.ResolvedRefs=Falsewith reasonPartiallyInvalidCertificateRefProgrammed=TrueWhich issue(s) this PR fixes:
Fixes #5730
Release Notes: Yes