Skip to content

fix: add indexing and processing for CRL references in ClientTrafficPolicies#7829

Merged
rudrakhp merged 1 commit intoenvoyproxy:mainfrom
rudrakhp:fix_crl_processing
Dec 29, 2025
Merged

fix: add indexing and processing for CRL references in ClientTrafficPolicies#7829
rudrakhp merged 1 commit intoenvoyproxy:mainfrom
rudrakhp:fix_crl_processing

Conversation

@rudrakhp
Copy link
Copy Markdown
Member

What type of PR is this?

fix: add indexing and processing for CRL references in ClientTrafficPolicies

What this PR does / why we need it:
Fix CRL ref processing.

Which issue(s) this PR fixes:

Fixes #7805

Release Notes: Yes

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 27, 2025

Codecov Report

❌ Patch coverage is 60.49383% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.72%. Comparing base (0247202) to head (6750a48).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/provider/kubernetes/indexers.go 0.00% 21 Missing and 1 partial ⚠️
internal/provider/kubernetes/controller.go 83.05% 8 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7829      +/-   ##
==========================================
+ Coverage   72.69%   72.72%   +0.02%     
==========================================
  Files         235      235              
  Lines       35035    35092      +57     
==========================================
+ Hits        25469    25520      +51     
- Misses       7751     7755       +4     
- Partials     1815     1817       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rudrakhp rudrakhp force-pushed the fix_crl_processing branch 3 times, most recently from 7b73ded to a493f70 Compare December 27, 2025 17:56
@rudrakhp rudrakhp marked this pull request as ready for review December 27, 2025 17:57
@rudrakhp rudrakhp requested a review from a team as a code owner December 27, 2025 17:57
…olicies

Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
@rudrakhp rudrakhp requested review from a team December 29, 2025 02:43
Copy link
Copy Markdown
Contributor

@jukie jukie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rudrakhp rudrakhp merged commit fe57c70 into envoyproxy:main Dec 29, 2025
52 of 55 checks passed
millermatt pushed a commit to millermatt/envoy-gateway that referenced this pull request Jan 4, 2026
…olicies (envoyproxy#7829)

Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
Signed-off-by: Matt Miller <millermatt@outlook.com>
rudrakhp added a commit to rudrakhp/gateway that referenced this pull request Jan 8, 2026
…olicies (envoyproxy#7829)

Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
rudrakhp added a commit that referenced this pull request Jan 9, 2026
* fix: set observedGeneration in envoy patch policy (#7715)

* fix: set observedGeneration in envoy patch policy

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>

* add release note

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>

---------

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>

* fix: add validation for request buffer limit (#7687)

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>

* fix: nil pointer error when applying BackendTrafficPolicy to HTTPRoute with no backendRefs (#7765)

* fix: checking route section name in backend traffic policy

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>

* fix: setting externalTrafficPolicy for NodePort service type (#7823)

Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>

* fix: add indexing and processing for CRL references in ClientTrafficPolicies (#7829)

Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>

* feat: change the benchmark report to json format (#6818)

* benchmark json output

Signed-off-by: zirain <zirain2009@gmail.com>

* fix

Signed-off-by: zirain <zirain2009@gmail.com>

* fix

Signed-off-by: zirain <zirain2009@gmail.com>

* fix lint

Signed-off-by: zirain <zirain2009@gmail.com>

* fix

Signed-off-by: zirain <zirain2009@gmail.com>

* revert

Signed-off-by: zirain <zirain2009@gmail.com>

* fix seconds

Signed-off-by: zirain <zirain2009@gmail.com>

---------

Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>

* bechmark: scale up RPS to test data plane CPU performance (#7810)

* Scale up RPS to test data plane CPU performance

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

* set duration to 120s

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

* discard invalid samples

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

* change scrape interval to 10s

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

* remove invalid cpu sampling data

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

* reduce duration to 60

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

* fix benchmark end time

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

* fix data plane benchmark start time

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

* increase test time to get more samples

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

* adjust rps for each scale

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

* address comments

Signed-off-by: Huabing(Robin) Zhao <zhaohuabing@gmail.com>

---------

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing(Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>

* fix: make port-forward worked for OTel collector on port 19001 (#7860)

Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>

* chore: fix goroutine leak (#7880)

fix goroutine leak

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>

* fix gen-check

Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>

---------

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing(Robin) Zhao <zhaohuabing@gmail.com>
Co-authored-by: Kota Kimura <86363983+kkk777-7@users.noreply.github.com>
Co-authored-by: zirain <zirain2009@gmail.com>
Co-authored-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ClientTrafficPolicy reports "failed to get crl from ref" even though the secret and permissions exist

3 participants