Skip to content

Run all core and extended conformance tests#780

Closed
arkodg wants to merge 4 commits intoenvoyproxy:mainfrom
arkodg:enable-extended-coformance
Closed

Run all core and extended conformance tests#780
arkodg wants to merge 4 commits intoenvoyproxy:mainfrom
arkodg:enable-extended-coformance

Conversation

@arkodg
Copy link
Copy Markdown
Contributor

@arkodg arkodg commented Dec 8, 2022

Signed-off-by: Arko Dasgupta arko@tetrate.io

@arkodg arkodg requested a review from a team as a code owner December 8, 2022 02:39
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 8, 2022 •
edited
Loading

Codecov Report

Merging #780 (369294e) into main (eec43d2) will decrease coverage by 0.13%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #780      +/-   ##
==========================================
- Coverage   62.25%   62.12%   -0.13%     
==========================================
  Files          55       55              
  Lines        8785     8785              
==========================================
- Hits         5469     5458      -11     
- Misses       2948     2957       +9     
- Partials      368      370       +2
Impacted Files Coverage Δ
internal/provider/kubernetes/helpers.go 79.72% <0.00%> (-3.38%) ⬇️
internal/provider/kubernetes/controller.go 50.56% <0.00%> (-0.68%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Xunzhuo
Copy link
Copy Markdown
Member

Xunzhuo commented Dec 8, 2022

The response header modifer is not getting merged yet, so it failed as expectations.

@arkodg arkodg force-pushed the enable-extended-coformance branch from dd12069 to d5876f6 Compare December 8, 2022 03:14
@arkodg arkodg marked this pull request as draft December 8, 2022 03:15
This was referenced Dec 8, 2022
Closed
Closed
Closed
Closed
@arkodg
Copy link
Copy Markdown
Contributor Author

arkodg commented Dec 8, 2022

blocked on #781 #782 #783 #784 #657

This was referenced Dec 9, 2022
Closed
Merged
@danehans
Copy link
Copy Markdown
Contributor

danehans commented Dec 14, 2022

@arkodg #793 adds the HTTPRouteReferenceGrant conformance test.

@arkodg arkodg force-pushed the enable-extended-coformance branch from d5876f6 to 73440fb Compare December 17, 2022 02:35
@arkodg arkodg force-pushed the enable-extended-coformance branch from 73440fb to 975cab5 Compare January 10, 2023 21:20
@arkodg
Copy link
Copy Markdown
Contributor Author

arkodg commented Jan 10, 2023

raised kubernetes-sigs/gateway-api#1638 to help ensure that we can easily run all tests (core and extended) automatically after updating to a newer gateway-api released version

@arkodg arkodg mentioned this pull request Jan 10, 2023
Closed
@arkodg arkodg added this to the 0.3.0 milestone Feb 2, 2023
@arkodg arkodg force-pushed the enable-extended-coformance branch 3 times, most recently from 369294e to e4690cd Compare February 7, 2023 20:22
This was referenced Feb 8, 2023
Closed
Closed
Closed
Closed
@arkodg arkodg force-pushed the enable-extended-coformance branch from e4690cd to b86de5e Compare February 8, 2023 01:04
@arkodg arkodg mentioned this pull request Feb 8, 2023
Merged
@arkodg arkodg force-pushed the enable-extended-coformance branch 2 times, most recently from cb6268e to 5dff177 Compare February 8, 2023 20:56
Run all core and extended conformance tests
3065e97 
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Arko Dasgupta added 3 commits February 8, 2023 17:50
update to main
fa332e7 
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
temp pin crd version
c238572 
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
test main
1a7205f 
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg force-pushed the enable-extended-coformance branch from 5dff177 to 1a7205f Compare February 9, 2023 01:50
@arkodg
Copy link
Copy Markdown
Contributor Author

arkodg commented Feb 9, 2023

moving this out to 0.4.0 since its unlikely the redirect tests issue will be resolved in the next few days before the v0.3.0 release

@arkodg arkodg modified the milestones: 0.3.0, 0.4.0-rc.1 Feb 9, 2023
@arkodg
Copy link
Copy Markdown
Contributor Author

arkodg commented Feb 9, 2023 •
edited
Loading

closing this PR since the skipped tests can be tracked with individual issues

@arkodg arkodg closed this Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.4.0-rc.1

Development

Successfully merging this pull request may close these issues.

4 participants

@arkodg @codecov-commenter @Xunzhuo @danehans