perf: use UnsafeDisableDeepCopy and cache for list Unstructured Resources#7704
Merged
arkodg merged 2 commits intoenvoyproxy:mainfrom Jan 14, 2026
Merged
perf: use UnsafeDisableDeepCopy and cache for list Unstructured Resources#7704arkodg merged 2 commits intoenvoyproxy:mainfrom
arkodg merged 2 commits intoenvoyproxy:mainfrom
Conversation
67e5523 to
0322ee5
Compare
arkodg
reviewed
Dec 11, 2025
| @@ -75,6 +76,11 @@ func New(ctx context.Context, restCfg *rest.Config, svrCfg *ec.Server, resources | |||
| HealthProbeBindAddress: healthProbeBindAddress, | |||
| LeaderElectionID: "5b9825d2.gateway.envoyproxy.io", | |||
| LeaderElectionNamespace: svrCfg.ControllerNamespace, | |||
| Client: client.Options{ | |||
Contributor
There was a problem hiding this comment.
is this section needed ? or can be do with only L155-157
Contributor
Author
There was a problem hiding this comment.
I think we should set the value to true to cache the unstructured resources here
1bd6fbb to
5ee3e68
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7704 +/- ##
==========================================
- Coverage 72.82% 72.82% -0.01%
==========================================
Files 235 235
Lines 35214 35219 +5
==========================================
+ Hits 25645 25648 +3
- Misses 7752 7754 +2
Partials 1817 1817 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
befe485 to
378f26f
Compare
ec1f7c2 to
01216af
Compare
Contributor
|
@fabian4 can this be scoped to only unstructured |
Contributor
|
Heads up: #7626 also calls for updating the unstructured I have a small, tested diff for |
cdae018 to
fad7603
Compare
Contributor
Author
|
I tried enable UnsafeDisableDeepCopy at the cache level but cache configuration requires explicit GVK registration. // Supported Gateway API GVKs
// controller-runtime cache requires concrete GVKs.
// Unstructured caching is enabled per GVK using unstructured.Unstructured
gatewayAPIGVKs = []schema.GroupVersionKind{
{Group: "gateway.networking.k8s.io", Version: "v1beta1", Kind: "Gateway"},
}
for _, gvk := range gatewayAPIGVKs {
u := &unstructured.Unstructured{}
u.SetGroupVersionKind(gvk)
mgrOpts.Cache.ByObject[u] = cache.ByObject{
UnsafeDisableDeepCopy: ptr.To(true),
}
}So maybe we enable it at each List() call is better. Thanks @aponysus |
arkodg
approved these changes
Jan 11, 2026
7c576a9 to
aac5c36
Compare
zirain
approved these changes
Jan 11, 2026
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…Resources Signed-off-by: fabian4 <fabian.v.bao@gmail.com>
…Resources Signed-off-by: fabian4 <fabian.v.bao@gmail.com>
aac5c36 to
4efefc6
Compare
andreik-n2
pushed a commit
to andreik-n2/gateway
that referenced
this pull request
Jan 15, 2026
…rces (envoyproxy#7704) * Performanceuse UnsafeDisableDeepCopy and cache for list Unstructured Resources Signed-off-by: fabian4 <fabian.v.bao@gmail.com>
SadmiB
pushed a commit
to SadmiB/gateway
that referenced
this pull request
Jan 30, 2026
…rces (envoyproxy#7704) * Performanceuse UnsafeDisableDeepCopy and cache for list Unstructured Resources Signed-off-by: fabian4 <fabian.v.bao@gmail.com> Signed-off-by: Sadmi Bouhafs <sadmibouhafs@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
perf: use UnsafeDisableDeepCopy and cache for list Unstructured Resources
What this PR does / why we need it:
use UnsafeDisableDeepCopy and cache for list Unstructured Resources
Which issue(s) this PR fixes:
Fixes #7626
Release Notes: Yes/No