Skip to content

feat: admin and metrics server hot reloading on config change#6488

Merged
arkodg merged 2 commits intoenvoyproxy:mainfrom
sudiptob2:feat/6340/pprof
Jul 17, 2025
Merged

feat: admin and metrics server hot reloading on config change#6488
arkodg merged 2 commits intoenvoyproxy:mainfrom
sudiptob2:feat/6340/pprof

Conversation

@sudiptob2
Copy link
Copy Markdown
Member

fixes #6340

@arkodg arkodg requested a review from zirain July 9, 2025 00:48
@sudiptob2 sudiptob2 changed the title feat: pprof hot reload - initial draft. feat: admin and metrics server hot reloading on config change Jul 9, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 9, 2025

Codecov Report

Attention: Patch coverage is 58.57143% with 29 lines in your changes missing coverage. Please review.

Project coverage is 71.05%. Comparing base (c05d438) to head (5351d7e).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
internal/metrics/register.go 64.86% 7 Missing and 6 partials ⚠️
internal/cmd/server.go 0.00% 10 Missing ⚠️
internal/admin/server.go 73.91% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6488      +/-   ##
==========================================
+ Coverage   70.74%   71.05%   +0.30%     
==========================================
  Files         220      220              
  Lines       37594    37630      +36     
==========================================
+ Hits        26597    26739     +142     
+ Misses       9432     9317     -115     
- Partials     1565     1574       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: sudipto baral <sudiptobaral.me@gmail.com>
Signed-off-by: sudipto baral <sudiptobaral.me@gmail.com>
@sudiptob2 sudiptob2 marked this pull request as ready for review July 9, 2025 14:03
@sudiptob2 sudiptob2 requested a review from a team as a code owner July 9, 2025 14:03
@arkodg arkodg added this to the v1.5.0-rc.1 Release milestone Jul 9, 2025
Copy link
Copy Markdown
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@arkodg arkodg requested review from a team July 17, 2025 01:03
@arkodg
Copy link
Copy Markdown
Contributor

arkodg commented Jul 17, 2025

@Xunzhuo this should help with #6331

@arkodg arkodg merged commit acc3da1 into envoyproxy:main Jul 17, 2025
28 checks passed
@sudiptob2 sudiptob2 deleted the feat/6340/pprof branch March 1, 2026 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enabling pprof requires rollout restart to be reflected

4 participants