-
Notifications
You must be signed in to change notification settings - Fork 708
Closed
Labels
area/configIssues related to config management, e.g. Config Manager, Config Sources, etc.Issues related to config management, e.g. Config Manager, Config Sources, etc.
Milestone
Description
Description:
When enabling pprof by changing admin.enablePprof to true in EG configmap a rollout restart is needed in order for the change to be reflected.
Repro steps:
- Deploy EG with default configuration into k8s cluster - pprof is disabled.
- Enable pprof by patching EG configmap with
admin.enablePprof=true. - Port-forward to EG pod admin server at port 19000.
- Try to access pprof endpoint at
http://localhost:19000/debug/pprof/- not accessible. - Perform rollout restart to EG deployment - now
http://localhost:19000/debug/pprof/will be accessible.
Looks like the root cause of this issue is the fact that admin server is only initialized once when EG server starts and is not included in the loader hook func.
The same applies for metrics server initialization.
Environment:
latest EG.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
area/configIssues related to config management, e.g. Config Manager, Config Sources, etc.Issues related to config management, e.g. Config Manager, Config Sources, etc.