docs: Enhance documentation for K8s Gateway API metrics.#5628
docs: Enhance documentation for K8s Gateway API metrics.#5628arkodg merged 5 commits intoenvoyproxy:mainfrom
Conversation
8e24d24 to
81ef5d0
Compare
There was a problem hiding this comment.
referring to moving these into https://github.com/envoyproxy/gateway/tree/main/charts/gateway-addons-helm which is the prerequisite step similar to other tasks so users dont need to install/upgrade one more thing
a5eaae9 to
439b31d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5628 +/- ##
==========================================
- Coverage 65.27% 65.26% -0.01%
==========================================
Files 213 213
Lines 34121 34121
==========================================
- Hits 22272 22269 -3
- Misses 10508 10510 +2
- Partials 1341 1342 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
142ad30 to
f83017f
Compare
There was a problem hiding this comment.
is this line still relevant, now that its provided via gateway-addons-helm ?
There was a problem hiding this comment.
can we also add EG resources here - xPolicies and HTTPRouteFilter
There was a problem hiding this comment.
should this live here or in a template ?
There was a problem hiding this comment.
Adding more context:
This config should be added to a file and then path to that file can be passed to kube-state-metrics
Here is an example
There was a problem hiding this comment.
We are using the Prometheus chart that comes with the Prometheus add-on. This chart does not seem to have that confg-file option
https://github.com/prometheus-community/helm-charts/blob/995b3392c82ecfdec4cbc432064b04b40c71c8aa/charts/kube-state-metrics/values.yaml#L452
There was a problem hiding this comment.
looks like the config file option is enabled by default: https://github.com/prometheus-community/helm-charts/blob/995b3392c82ecfdec4cbc432064b04b40c71c8aa/charts/kube-state-metrics/templates/deployment.yaml#L139C47-L139C83
and when you add those metrics as config it already goes into a configmap so what you have done is sufficient then. ✔️
6d9d743 to
21a87af
Compare
site/content/en/latest/tasks/observability/gateway-api-metrics.md
Outdated
Show resolved
Hide resolved
a75dd90 to
344030f
Compare
site/content/en/latest/tasks/observability/gateway-api-metrics.md
Outdated
Show resolved
Hide resolved
1fcf2d7 to
63cb8a9
Compare
63cb8a9 to
8042e97
Compare
Signed-off-by: sudipto baral <sudiptobaral.me@gmail.com>
Signed-off-by: sudipto baral <sudiptobaral.me@gmail.com>
Signed-off-by: sudipto baral <sudiptobaral.me@gmail.com>
Signed-off-by: sudipto baral <sudiptobaral.me@gmail.com>
Signed-off-by: sudipto baral <sudiptobaral.me@gmail.com>
8042e97 to
fdce08f
Compare
Tasks
kube-state-metricsusing Add-ons charts.Fixes #5625
Release Notes: No