Expose root command of envoy-gateway#5407
Merged
arkodg merged 2 commits intoenvoyproxy:mainfrom Mar 4, 2025
Merged
Conversation
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
zirain
previously approved these changes
Mar 4, 2025
Member
Author
|
oh wait sorry lint |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5407 +/- ##
==========================================
- Coverage 65.12% 65.01% -0.11%
==========================================
Files 213 212 -1
Lines 33592 33579 -13
==========================================
- Hits 21878 21833 -45
- Misses 10389 10416 +27
- Partials 1325 1330 +5 ☔ View full report in Codecov by Sentry. |
cnvergence
approved these changes
Mar 4, 2025
Member
Author
|
looks like there's a flaky little guy |
arkodg
approved these changes
Mar 4, 2025
mathetake
added a commit
to envoyproxy/ai-gateway
that referenced
this pull request
Mar 5, 2025
**Commit Message** The CLI's standalone mode needs to use Envoy Gateway's latest patch [1] that allows us to use it inside our CLI. This upgrades the EG dependency version to the latest. It is not compatible with the latest cel-go, so this also pins it to 0.22 until the upstream k8s.io/apiserver dependency [2] issue is resolved. This commit is separated from the standalone implementation commit as the upgrade results in a CRD generation which is not relevant to the change. 1: envoyproxy/gateway#5407 2: https://github.com/kubernetes/apiserver/issues/116 **Related Issues/PRs (if applicable)** This is a preparation for #458 Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Refactors the envoy-gateway CLI packages around main program.
What this PR does / why we need it:
Refactors the envoy-gateway CLI packages around main program so that envoyproxy/ai-gateway project can utilize the standalone mode as part of its CLI.
Release Notes: No