dont reset replicas when hpa is set#5021
Merged
arkodg merged 1 commit intoenvoyproxy:mainfrom Jan 9, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5021 +/- ##
==========================================
+ Coverage 66.74% 66.77% +0.02%
==========================================
Files 209 209
Lines 32264 32255 -9
==========================================
+ Hits 21535 21537 +2
+ Misses 9432 9423 -9
+ Partials 1297 1295 -2 ☔ View full report in Codecov by Sentry. |
cnvergence
approved these changes
Jan 9, 2025
zirain
approved these changes
Jan 9, 2025
This is no longer needed after envoyproxy#2816 was merged Relates to envoyproxy#4983 (comment) Signed-off-by: Arko Dasgupta <arko@tetrate.io>
arkodg
pushed a commit
to arkodg/gateway
that referenced
this pull request
Apr 17, 2025
no longer true after envoyproxy#5021 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
shawnh2
pushed a commit
that referenced
this pull request
Apr 19, 2025
no longer true after #5021 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is no longer needed after
#2816 was merged
Relates to #4983 (comment)