Skip to content

ci: enable ipv6/dual test#4550

Closed
zirain wants to merge 8 commits intoenvoyproxy:mainfrom
zirain:ipv6-test
Closed

ci: enable ipv6/dual test#4550
zirain wants to merge 8 commits intoenvoyproxy:mainfrom
zirain:ipv6-test

Conversation

@zirain
Copy link
Copy Markdown
Member

@zirain zirain commented Oct 28, 2024

No description provided.

@zirain zirain requested a review from a team as a code owner October 28, 2024 10:40
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 78.78788% with 14 lines in your changes missing coverage. Please review.

Project coverage is 65.45%. Comparing base (b0c6f8c) to head (176ccb8).

Files with missing lines Patch % Lines
internal/xds/bootstrap/bootstrap.go 53.84% 4 Missing and 2 partials ⚠️
internal/cmd/envoy/shutdown_manager.go 0.00% 3 Missing ⚠️
internal/gatewayapi/listener.go 57.14% 2 Missing and 1 partial ⚠️
internal/utils/net/ip.go 75.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4550      +/-   ##
==========================================
- Coverage   65.47%   65.45%   -0.02%     
==========================================
  Files         211      212       +1     
  Lines       31858    31902      +44     
==========================================
+ Hits        20859    20882      +23     
- Misses       9755     9774      +19     
- Partials     1244     1246       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zirain zirain changed the title test ipv6 ci: enable ipv6/dual test Oct 28, 2024
@zhaohuabing
Copy link
Copy Markdown
Member

zhaohuabing commented Oct 28, 2024 •
edited
Loading

@zirain Do we also need to configure Kubernetes and Github nodes for IPv6/Dual-stack support?

arkodg
arkodg previously approved these changes Oct 28, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg
Copy link
Copy Markdown
Contributor

arkodg commented Oct 28, 2024

cc @juwon8891, when the ipFamily listener e2e tests are added, we'll need to only run it on the ipv6 and dual enabled clusters

@zirain
Copy link
Copy Markdown
Member Author

zirain commented Oct 28, 2024

After envoyproxy/ratelimit#748 merged still need some code change to pass ipv6 test.

@arkodg
Copy link
Copy Markdown
Contributor

arkodg commented Oct 28, 2024 •
edited
Loading

thanks @zirain, can we track this with a issue - "Global Ratelimit doesnt working for ipv6 only cluster", and add the ipv6 only element in the matrix then

@zirain
Copy link
Copy Markdown
Member Author

zirain commented Oct 28, 2024

the dual stack actually didn't work as expected, because RateLimit only work in IPv4 mode, it's not a real dual.

@zirain zirain mentioned this pull request Oct 28, 2024
Closed
@zirain zirain added the hold do not merge label Oct 28, 2024
@zhaohuabing
Copy link
Copy Markdown
Member

zhaohuabing commented Oct 29, 2024

Should we cherry-pick this to v1.2 branch and upgrade the ratelimit image after envoyproxy/ratelimit#748 ?

@zirain
Copy link
Copy Markdown
Member Author

zirain commented Oct 29, 2024

Should we cherry-pick this to v1.2 branch and upgrade the ratelimit image after envoyproxy/ratelimit#748 ?

I don't think envoyproxy/ratelimit#748 will be merged soon.

@zirain
Copy link
Copy Markdown
Member Author

zirain commented Oct 29, 2024 

Error: failed to get config: cannot unmarshal the configuration: decoding failed due to the following error(s):

error decoding 'service.telemetry': failing to parse metrics address "fd00:10:244::16:8888": address fd00:10:244::16:8888: too many colons in address
2024/10/29 01:07:28 collector server run finished with error: failed to get config: cannot unmarshal the configuration: decoding failed due to the following error(s):

error decoding 'service.telemetry': failing to parse metrics address "fd00:10:244::16:8888": address fd00:10:244::16:8888: too many colons in address

@zirain zirain mentioned this pull request Oct 29, 2024
Merged
@zirain
Copy link
Copy Markdown
Member Author

zirain commented Oct 29, 2024

wait #4559 and #4525

@zirain
Copy link
Copy Markdown
Member Author

zirain commented Oct 29, 2024 •
edited
Loading

More errors:

2024-10-29T10:01:56.1526498Z === RUN   TestE2E/FileAccessLog
2024-10-29T10:01:56.1527650Z     conformance.go:72: 2024-10-29T10:01:56.150860034Z: Applying testdata/accesslog-file.yaml
2024-10-29T10:01:56.1542009Z     apply.go:271: 2024-10-29T10:01:56.153913758Z: Creating accesslog-file HTTPRoute
2024-10-29T10:01:56.1600215Z === RUN   TestE2E/FileAccessLog/Positive
2024-10-29T10:01:56.1660350Z     helpers.go:609: 2024-10-29T10:01:56.165689139Z: Route gateway-conformance-infra/accesslog-file expected 1 Parents got 0
2024-10-29T10:01:57.1659483Z     helpers.go:609: 2024-10-29T10:01:57.165604331Z: Conditions matched expectations
2024-10-29T10:01:57.1661907Z     helpers.go:609: 2024-10-29T10:01:57.165654616Z: Route gateway-conformance-infra/accesslog-file Parents matched expectations
2024-10-29T10:01:57.1683656Z     accesslog.go:58: 2024-10-29T10:01:57.167930535Z: Making GET request to http://[fc00:f853:ccd:e793::cb]/file
2024-10-29T10:01:57.1685288Z     roundtripper.go:219: 2024-10-29T10:01:57.168145919Z: Sending Request:
2024-10-29T10:01:57.1686149Z         < GET /file HTTP/1.1
2024-10-29T10:01:57.1687179Z         < Host: [fc00:f853:ccd:e793::cb]
2024-10-29T10:01:57.1687750Z         < User-Agent: Go-http-client/1.1
2024-10-29T10:01:57.1688172Z         < X-Echo-Set-Header: 
2024-10-29T10:01:57.1688839Z         < X-Envoy-Logged: 1
2024-10-29T10:01:57.1689523Z         < Accept-Encoding: gzip
2024-10-29T10:01:57.1690065Z         < 
2024-10-29T10:01:57.1690485Z         < 
2024-10-29T10:01:57.1690908Z         
2024-10-29T10:01:57.1691327Z         
2024-10-29T10:02:00.2328419Z     http.go:235: 2024-10-29T10:02:00.232468573Z: Request failed, not ready yet: Get "http://[fc00:f853:ccd:e793::cb]/file": dial tcp [fc00:f853:ccd:e793::cb]:80: connect: no route to host (after 1.333µs)

istioctl pc ep -n envoy-gateway-system envoy-gateway-conformance-infra-all-namespaces-302def45-66hbns2 --proxy-admin-port 19000
ENDPOINT                   STATUS      OUTLIER CHECK     CLUSTER
127.0.0.1:19000            HEALTHY     OK                prometheus_stats
fd00:10:96::64fe:18002     HEALTHY     OK                wasm_cluster
fd00:10:96::ee6f:4317      HEALTHY     OK                otel_metric_sink_0

@zirain
Copy link
Copy Markdown
Member Author

zirain commented Oct 30, 2024 

k logs -n gateway-conformance-infra grpc-ext-auth-67d997ccdf-cxfmj
go: downloading github.com/envoyproxy/go-control-plane v0.12.0
go: downloading github.com/golang/protobuf v1.5.4
go: downloading google.golang.org/genproto/googleapis/rpc v0.0.0-20240304212257-790db918fca8
go: downloading google.golang.org/grpc v1.62.1
main.go:15:2: github.com/envoyproxy/go-control-plane@v0.12.0: Get "https://proxy.golang.org/github.com/envoyproxy/go-control-plane/@v/v0.12.0.zip": dial tcp: lookup proxy.golang.org on [fd00:10:96::a]:53: server misbehaving
main.go:16:2: github.com/envoyproxy/go-control-plane@v0.12.0: Get "https://proxy.golang.org/github.com/envoyproxy/go-control-plane/@v/v0.12.0.zip": dial tcp: lookup proxy.golang.org on [fd00:10:96::a]:53: server misbehaving
main.go:17:2: github.com/golang/protobuf@v1.5.4: Get "https://proxy.golang.org/github.com/golang/protobuf/@v/v1.5.4.zip": dial tcp: lookup proxy.golang.org on [fd00:10:96::a]:53: server misbehaving
main.go:18:2: google.golang.org/genproto/googleapis/rpc@v0.0.0-20240304212257-790db918fca8: Get "https://proxy.golang.org/google.golang.org/genproto/googleapis/rpc/@v/v0.0.0-20240304212257-790db918fca8.zip": dial tcp: lookup proxy.golang.org on [fd00:10:96::a]:53: server misbehaving
main.go:19:2: google.golang.org/genproto/googleapis/rpc@v0.0.0-20240304212257-790db918fca8: Get "https://proxy.golang.org/google.golang.org/genproto/googleapis/rpc/@v/v0.0.0-20240304212257-790db918fca8.zip": dial tcp: lookup proxy.golang.org on [fd00:10:96::a]:53: server misbehaving
main.go:20:2: google.golang.org/grpc@v1.62.1: Get "https://proxy.golang.org/google.golang.org/grpc/@v/v1.62.1.zip": dial tcp: lookup proxy.golang.org on [fd00:10:96::a]:53: server misbehaving
main.go:21:2: google.golang.org/grpc@v1.62.1: Get "https://proxy.golang.org/google.golang.org/grpc/@v/v1.62.1.zip": dial tcp: lookup proxy.golang.org on [fd00:10:96::a]:53: server misbehaving

@zirain zirain mentioned this pull request Oct 30, 2024
Closed
zirain added 6 commits October 30, 2024 14:54
@zirain
test ipv6
6c05aa4 
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain
lint
79fc19a 
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain
use env
b0563e0 
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain
fix listen bug on ipv6
21472ea 
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain
use grafana alloy instead of fluent-bit
5afa6ad 
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain
socket_address base on POD_IP
7cba47e 
Signed-off-by: zirain <zirain2009@gmail.com>
zirain added 2 commits October 30, 2024 14:54
@zirain
Revert "feat: set full URI for the envoy-gateway service using name a…
652b90e 
…nd namespace (envoyproxy#4533)"

This reverts commit 3e8730f.

Signed-off-by: zirain <zirain2009@gmail.com>
@zirain
fix listener address
176ccb8 
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain mentioned this pull request Oct 30, 2024
Closed
@zirain zirain closed this Oct 30, 2024
@zirain zirain mentioned this pull request Oct 30, 2024
Merged
@zirain zirain deleted the ipv6-test branch January 12, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arkodg arkodg arkodg left review comments

Assignees

No one assigned

Labels

hold do not merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zirain @zhaohuabing @arkodg