Skip to content

make proto configurable#748

Closed
zirain wants to merge 1 commit intoenvoyproxy:mainfrom
zirain:make-proto-configurable
Closed

make proto configurable#748
zirain wants to merge 1 commit intoenvoyproxy:mainfrom
zirain:make-proto-configurable

Conversation

@zirain
Copy link
Copy Markdown
Member

@zirain zirain commented Oct 28, 2024

make Proto configurable cause I want to use the combination of reuseport.Listen(“tcp6”, “:8881"), that will listen on [::]:8881 and you can access it with [::]:8881 and 127.0.0.1:8881

IMO, this more like a bug from reuseport package? Because I think reuseport.Listen(“tcp”, “:8881") should be the right way to do this, but it's hard to change a package which isn't updated for three years.

Signed-off-by: zirain <zirain2009@gmail.com>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 1, 2024

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale label Dec 1, 2024
@zirain
Copy link
Copy Markdown
Member Author

zirain commented Dec 2, 2024

not stale

@github-actions github-actions bot removed the stale label Dec 2, 2024
@zirain zirain closed this Dec 3, 2024
@zirain zirain deleted the make-proto-configurable branch December 3, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants