Merged
Conversation
Signed-off-by: zirain <zirain2009@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4459 +/- ##
==========================================
+ Coverage 65.80% 65.82% +0.02%
==========================================
Files 200 200
Lines 24277 24284 +7
==========================================
+ Hits 15976 15986 +10
Misses 7159 7159
+ Partials 1142 1139 -3 ☔ View full report in Codecov by Sentry. |
arkodg
reviewed
Oct 16, 2024
arkodg
approved these changes
Oct 16, 2024
shawnh2
approved these changes
Oct 17, 2024
Contributor
|
should we backport this @zirain ? |
Member
Author
|
both or not |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
following up: #4430
e2e tracked in: #4453