Skip to content

infra: use labels when deleting infra#4430

Merged
shawnh2 merged 4 commits intoenvoyproxy:mainfrom
zirain:infra-delete
Oct 16, 2024
Merged

infra: use labels when deleting infra#4430
shawnh2 merged 4 commits intoenvoyproxy:mainfrom
zirain:infra-delete

Conversation

@zirain
Copy link
Copy Markdown
Member

@zirain zirain commented Oct 12, 2024 •
edited
Loading

xref: #4380

@zirain
infra: use labels when deleting infra
1e73bbf 
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain requested a review from a team as a code owner October 12, 2024 06:06
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 12, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 51.28205% with 19 lines in your changes missing coverage. Please review.

Project coverage is 65.84%. Comparing base (f1df0c9) to head (f3f458b).
Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
...ternal/infrastructure/kubernetes/infra_resource.go 57.14% 15 Missing ⚠️
...frastructure/kubernetes/proxy/resource_provider.go 0.00% 2 Missing ⚠️
...tructure/kubernetes/ratelimit/resource_provider.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4430      +/-   ##
==========================================
+ Coverage   65.81%   65.84%   +0.03%     
==========================================
  Files         200      200              
  Lines       24171    24277     +106     
==========================================
+ Hits        15907    15986      +79     
- Misses       7129     7152      +23     
- Partials     1135     1139       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zirain added 2 commits October 12, 2024 14:36
@zirain
lint
eb0d75d 
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain
more lint
d2486a1 
Signed-off-by: zirain <zirain2009@gmail.com>
shawnh2
shawnh2 previously approved these changes Oct 13, 2024
View reviewed changes
@zirain zirain requested review from a team October 15, 2024 04:49
@zirain zirain mentioned this pull request Oct 15, 2024
Closed
arkodg
arkodg reviewed Oct 15, 2024
View reviewed changes
@arkodg
Copy link
Copy Markdown
Contributor

arkodg commented Oct 15, 2024

thanks for looking into this @zirain, can the issue title be edited to Relates to instead of Fixes since #4380 requires some additional fixes that deal with transitioning from default name infra -> custom infra infra (default name infra needs to be deleted) and vice versa

@zirain
Copy link
Copy Markdown
Member Author

zirain commented Oct 15, 2024

/retest

@zirain zirain requested a review from arkodg October 15, 2024 23:50
@zirain
use stableSelector()
f3f458b 
Signed-off-by: zirain <zirain2009@gmail.com>
@arkodg arkodg requested review from a team and shawnh2 October 16, 2024 04:55
@shawnh2 shawnh2 merged commit 958df48 into envoyproxy:main Oct 16, 2024
@zirain zirain deleted the infra-delete branch October 16, 2024 06:07
This was referenced Oct 16, 2024
Closed
Merged
@guydc guydc mentioned this pull request Oct 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arkodg arkodg arkodg approved these changes

@shawnh2 shawnh2 shawnh2 approved these changes

Assignees

No one assigned

Labels

cherrypick/release-v1.1.3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zirain @arkodg @shawnh2