docs: add helm-version and yaml-version shortcode#3766
Merged
zirain merged 5 commits intoenvoyproxy:mainfrom Jul 24, 2024
Merged
docs: add helm-version and yaml-version shortcode#3766zirain merged 5 commits intoenvoyproxy:mainfrom
zirain merged 5 commits intoenvoyproxy:mainfrom
Conversation
be93ea4 to
52ac84e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3766 +/- ##
==========================================
- Coverage 67.39% 67.38% -0.02%
==========================================
Files 183 183
Lines 22435 22435
==========================================
- Hits 15121 15117 -4
- Misses 6226 6229 +3
- Partials 1088 1089 +1 ☔ View full report in Codecov by Sentry. |
Member
Author
|
/retest |
zirain
commented
Jul 6, 2024
zirain
commented
Jul 6, 2024
7ea97d7 to
9b7f420
Compare
Member
|
@zirain Why do we need this? |
Member
Author
This will simply the work when cutting a new doc version. |
shawnh2
previously approved these changes
Jul 23, 2024
Contributor
shawnh2
left a comment
There was a problem hiding this comment.
LGTM, thanks for optimizing this!
a844c98 to
148f54e
Compare
Signed-off-by: zirain <zirain2009@gmail.com>
148f54e to
1216b1c
Compare
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
d05ab85 to
d775201
Compare
d775201 to
c1dace9
Compare
shawnh2
reviewed
Jul 23, 2024
| 2. Create a release announcement. Refer to [PR #635] as an example release announcement. | ||
| 3. Include the release in the compatibility matrix. Refer to [PR #1002] as an example. | ||
| 4. Generate the versioned release docs: | ||
| 1. Create a release announcement. Refer to [PR #635] as an example release announcement. |
Contributor
There was a problem hiding this comment.
nit: those numbers are not correct
Member
Author
|
wait for #3910 |
shawnh2
approved these changes
Jul 24, 2024
Member
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thi will make it simpler to manage the version of helm chart and yaml file in doc site.