doc: utilize hugo boilerplates for latest#3910
Merged
zirain merged 4 commits intoenvoyproxy:mainfrom Jul 24, 2024
Merged
Conversation
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
zirain
reviewed
Jul 20, 2024
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3910 +/- ##
==========================================
+ Coverage 67.39% 67.42% +0.02%
==========================================
Files 183 183
Lines 22435 22435
==========================================
+ Hits 15121 15126 +5
+ Misses 6226 6222 -4
+ Partials 1088 1087 -1 ☔ View full report in Codecov by Sentry. |
zhaohuabing
reviewed
Jul 22, 2024
Member
There was a problem hiding this comment.
It's great to see the reduction of duplication! Just on nit: should we use the same template for UDPRoute and TCPRoute? The description of testing HTTPRoute in the template is irrelevant in the context of UDPRoute and TCPRoute.
Contributor
Author
There was a problem hiding this comment.
Indeed, but I think it's fine for now, since it's in the Prerequisites section, users should get everything work before they take any further steps.
cnvergence
approved these changes
Jul 23, 2024
zirain
approved these changes
Jul 24, 2024
Member
|
Link check fails becase of there's an issue with tetrate.io |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #3621