feat: implement zipkin tracing#3668
Merged
zirain merged 10 commits intoenvoyproxy:mainfrom Jun 25, 2024
Merged
Conversation
Signed-off-by: Alex Marston <alexander.marston@imaginecurve.com>
Signed-off-by: Alex Marston <alexander.marston@imaginecurve.com>
Signed-off-by: Alex Marston <alexander.marston@imaginecurve.com>
Signed-off-by: Alex Marston <alexander.marston@imaginecurve.com>
Signed-off-by: Alex Marston <alexander.marston@imaginecurve.com>
676d6f0 to
f4270e9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3668 +/- ##
==========================================
+ Coverage 68.28% 68.33% +0.04%
==========================================
Files 170 170
Lines 20760 20780 +20
==========================================
+ Hits 14175 14199 +24
+ Misses 5566 5563 -3
+ Partials 1019 1018 -1 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
/retest |
arkodg
reviewed
Jun 25, 2024
Signed-off-by: Alex Marston <alexander.marston@imaginecurve.com>
zirain
approved these changes
Jun 25, 2024
Member
zirain
left a comment
There was a problem hiding this comment.
LGTM, thanks for adding this,
Would be better to add e2e test in the following.
bjlhlin
pushed a commit
to bjlhlin/gateway
that referenced
this pull request
Jun 26, 2024
* feat: initial zipkin tracing support Signed-off-by: Alex Marston <alexander.marston@imaginecurve.com> * add zipkin tracing example Signed-off-by: Alex Marston <alexander.marston@imaginecurve.com> * update testdata Signed-off-by: Alex Marston <alexander.marston@imaginecurve.com> * update host in testdata Signed-off-by: Alex Marston <alexander.marston@imaginecurve.com> * update host in testdata Signed-off-by: Alex Marston <alexander.marston@imaginecurve.com> * lint Signed-off-by: Alex Marston <alexander.marston@imaginecurve.com> * handle if pointer is null Signed-off-by: Alex Marston <alexander.marston@imaginecurve.com> --------- Signed-off-by: Alex Marston <alexander.marston@imaginecurve.com> Signed-off-by: bjlhlin <lihonglin1@jd.com>
This was referenced Jun 27, 2024
zirain
reviewed
Jul 4, 2024
| typedExtensionProtocolOptions: | ||
| envoy.extensions.upstreams.http.v3.HttpProtocolOptions: | ||
| '@type': type.googleapis.com/envoy.extensions.upstreams.http.v3.HttpProtocolOptions | ||
| explicitHttpConfig: |
Member
There was a problem hiding this comment.
this's not right, zipkin is HTTP.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feat: implement zipkin tracing
What this PR does / why we need it:
This PR adds support for the Zipkin tracer.
Which issue(s) this PR fixes:
Fixes #1827
API Change: #3630