fix: envoy shutdown flaky test#3646
Merged
arkodg merged 1 commit intoenvoyproxy:mainfrom Jun 22, 2024
Merged
Conversation
Signed-off-by: Guy Daich <guy.daich@sap.com>
Contributor
|
the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3646 +/- ##
==========================================
+ Coverage 68.27% 68.30% +0.03%
==========================================
Files 170 170
Lines 20760 20760
==========================================
+ Hits 14174 14181 +7
+ Misses 5566 5560 -6
+ Partials 1020 1019 -1 ☔ View full report in Codecov by Sentry. |
shawnh2
approved these changes
Jun 22, 2024
bjlhlin
pushed a commit
to bjlhlin/gateway
that referenced
this pull request
Jun 24, 2024
delay readdiness to allow XDS sync Signed-off-by: Guy Daich <guy.daich@sap.com> Signed-off-by: “bjlhlin” <“lihonglin1@jd.com”> Signed-off-by: bjlhlin <lihonglin1@jd.com>
bjlhlin
pushed a commit
to bjlhlin/gateway
that referenced
this pull request
Jun 26, 2024
delay readdiness to allow XDS sync Signed-off-by: Guy Daich <guy.daich@sap.com> Signed-off-by: bjlhlin <lihonglin1@jd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR delays readiness of envoy to allow XDS sync as discussed in #2810. This is done specifically for the upgrade test suite gateway class.
Test flakiness seems to be related to 404 responses in early stages of the load test, which likely indicates that new proxy instances are ready before being programmed.
--- FAIL: TestEGUpgrade (230.50s) --- PASS: TestEGUpgrade/EGUpgrade (152.90s) --- PASS: TestEGUpgrade/EGUpgrade/Upgrade_from_an_older_eg_release_should_succeed (152.89s) --- FAIL: TestEGUpgrade/EnvoyShutdown (68.06s) --- FAIL: TestEGUpgrade/EnvoyShutdown/All_requests_must_succeed (68.04s) utils.go:176: failed to create load: error 404 for http://172.18.255.208/envoy-shutdown (82 bytes) utils.go:185: Load completed after 0s with 2 requests, 0 success, 2 failures and 2 errorsWhich issue(s) this PR fixes:
Fixes #3262