feat: support attaching EnvoyProxy resource to Gateways#3532
Merged
zirain merged 24 commits intoenvoyproxy:mainfrom Jun 20, 2024
Merged
feat: support attaching EnvoyProxy resource to Gateways#3532zirain merged 24 commits intoenvoyproxy:mainfrom
zirain merged 24 commits intoenvoyproxy:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3532 +/- ##
==========================================
- Coverage 68.36% 68.25% -0.12%
==========================================
Files 170 170
Lines 20711 20760 +49
==========================================
+ Hits 14159 14169 +10
- Misses 5530 5570 +40
+ Partials 1022 1021 -1 ☔ View full report in Codecov by Sentry. |
Contributor
|
thanks for picking this one up @haoqixu, looking forward to reviewing it once its ready ! |
8d735fb to
19d9764
Compare
Contributor
Author
|
/retest |
shawnh2
reviewed
Jun 6, 2024
Contributor
There was a problem hiding this comment.
is there anyway to wrap these up into a helper function ? just like what we did in
arkodg
reviewed
Jun 7, 2024
Contributor
There was a problem hiding this comment.
hey is this refactor related to this GH issue, if not, can we seperate it from this PR ?
Contributor
There was a problem hiding this comment.
hey still seeing these refactors, so unresolving this one
Contributor
Author
There was a problem hiding this comment.
The updates in GetRouteParentContext and GetParentReferences is necessary. UpgradeParentReferences will do a deepcopy for the pointer fields and makes ParentReferences unable to be used as map keys.
Contributor
There was a problem hiding this comment.
Sorry for the delay. The updates in GetRouteParentContext and GetParentReferences is indeed necessary, since the ParentRef for xRoute got all upgraded to v1.
So the codes here do need a clean-up, but we can track this in a separate issue.
arkodg
reviewed
Jun 7, 2024
arkodg
reviewed
Jun 7, 2024
b1125c1 to
19b3d24
Compare
Contributor
Author
|
/retest |
arkodg
reviewed
Jun 7, 2024
arkodg
reviewed
Jun 7, 2024
arkodg
reviewed
Jun 7, 2024
arkodg
reviewed
Jun 7, 2024
arkodg
reviewed
Jun 7, 2024
Contributor
There was a problem hiding this comment.
cc @zirain since you had moved this code below in a prev commit
Signed-off-by: haoqixu <hq.xu0o0@gmail.com>
Signed-off-by: haoqixu <hq.xu0o0@gmail.com>
Signed-off-by: haoqixu <hq.xu0o0@gmail.com>
Signed-off-by: haoqixu <hq.xu0o0@gmail.com>
Signed-off-by: haoqixu <hq.xu0o0@gmail.com>
Signed-off-by: haoqixu <hq.xu0o0@gmail.com>
Signed-off-by: haoqixu <hq.xu0o0@gmail.com>
Signed-off-by: haoqixu <hq.xu0o0@gmail.com>
Signed-off-by: haoqixu <hq.xu0o0@gmail.com>
Signed-off-by: haoqixu <hq.xu0o0@gmail.com>
Signed-off-by: haoqixu <hq.xu0o0@gmail.com>
Signed-off-by: haoqixu <hq.xu0o0@gmail.com>
Contributor
Author
done |
zirain
approved these changes
Jun 20, 2024
zirain
approved these changes
Jun 20, 2024
This was referenced Jun 20, 2024
bjlhlin
pushed a commit
to bjlhlin/gateway
that referenced
this pull request
Jun 24, 2024
) * refactor: rename EnvoyProxy field Signed-off-by: haoqixu <hq.xu0o0@gmail.com> * feat(controller): process gateway.infrastructure.parametersref Signed-off-by: haoqixu <hq.xu0o0@gmail.com> * feat(translator): support attaching EnvoyProxy to Gateways Signed-off-by: haoqixu <hq.xu0o0@gmail.com> * chore: fix lint Signed-off-by: haoqixu <hq.xu0o0@gmail.com> * chore: update generated code Signed-off-by: haoqixu <hq.xu0o0@gmail.com> * chore: fix test Signed-off-by: haoqixu <hq.xu0o0@gmail.com> * test: gateway-with-infrastructure-parametersref Signed-off-by: haoqixu <hq.xu0o0@gmail.com> * test: add more cases Signed-off-by: haoqixu <hq.xu0o0@gmail.com> * fix: EnvoyExtensionPolicy status Signed-off-by: haoqixu <hq.xu0o0@gmail.com> * trigger reconciliation for envoyproxies Signed-off-by: haoqixu <hq.xu0o0@gmail.com> * chore: rename processGCParamsRef as suggested Signed-off-by: haoqixu <hq.xu0o0@gmail.com> * chore: add comments to Resources Signed-off-by: haoqixu <hq.xu0o0@gmail.com> * refactor: update as suggested Signed-off-by: haoqixu <hq.xu0o0@gmail.com> * refactor: extract resources.GetEnvoyProxy Signed-off-by: haoqixu <hq.xu0o0@gmail.com> * refactor: move attachEnvoyProxy into GatewayContext.ResetListeners Signed-off-by: haoqixu <hq.xu0o0@gmail.com> * refactor: change ListenerContext.gateway to GatewayContext Signed-off-by: haoqixu <hq.xu0o0@gmail.com> * refactor: move getIRKey out of inner loop Signed-off-by: haoqixu <hq.xu0o0@gmail.com> * fix: reset *ir.ExtAuth for each gateway Signed-off-by: haoqixu <hq.xu0o0@gmail.com> * refactor: continue early to reduce nesting Signed-off-by: haoqixu <hq.xu0o0@gmail.com> * refactor: rename envoyProxies and ClassEnvoyProxy Signed-off-by: haoqixu <hq.xu0o0@gmail.com> * rename json/yaml name for envoyproxy Signed-off-by: haoqixu <hq.xu0o0@gmail.com> * fix: pass the right envoyProxy to t.IsEnvoyServiceRouting Signed-off-by: haoqixu <hq.xu0o0@gmail.com> * test: add more cases Signed-off-by: haoqixu <hq.xu0o0@gmail.com> * chore: regenerate Signed-off-by: haoqixu <hq.xu0o0@gmail.com> --------- Signed-off-by: haoqixu <hq.xu0o0@gmail.com> Signed-off-by: “bjlhlin” <“lihonglin1@jd.com”> Signed-off-by: bjlhlin <lihonglin1@jd.com>
bjlhlin
pushed a commit
to bjlhlin/gateway
that referenced
this pull request
Jun 26, 2024
) * refactor: rename EnvoyProxy field Signed-off-by: haoqixu <hq.xu0o0@gmail.com> * feat(controller): process gateway.infrastructure.parametersref Signed-off-by: haoqixu <hq.xu0o0@gmail.com> * feat(translator): support attaching EnvoyProxy to Gateways Signed-off-by: haoqixu <hq.xu0o0@gmail.com> * chore: fix lint Signed-off-by: haoqixu <hq.xu0o0@gmail.com> * chore: update generated code Signed-off-by: haoqixu <hq.xu0o0@gmail.com> * chore: fix test Signed-off-by: haoqixu <hq.xu0o0@gmail.com> * test: gateway-with-infrastructure-parametersref Signed-off-by: haoqixu <hq.xu0o0@gmail.com> * test: add more cases Signed-off-by: haoqixu <hq.xu0o0@gmail.com> * fix: EnvoyExtensionPolicy status Signed-off-by: haoqixu <hq.xu0o0@gmail.com> * trigger reconciliation for envoyproxies Signed-off-by: haoqixu <hq.xu0o0@gmail.com> * chore: rename processGCParamsRef as suggested Signed-off-by: haoqixu <hq.xu0o0@gmail.com> * chore: add comments to Resources Signed-off-by: haoqixu <hq.xu0o0@gmail.com> * refactor: update as suggested Signed-off-by: haoqixu <hq.xu0o0@gmail.com> * refactor: extract resources.GetEnvoyProxy Signed-off-by: haoqixu <hq.xu0o0@gmail.com> * refactor: move attachEnvoyProxy into GatewayContext.ResetListeners Signed-off-by: haoqixu <hq.xu0o0@gmail.com> * refactor: change ListenerContext.gateway to GatewayContext Signed-off-by: haoqixu <hq.xu0o0@gmail.com> * refactor: move getIRKey out of inner loop Signed-off-by: haoqixu <hq.xu0o0@gmail.com> * fix: reset *ir.ExtAuth for each gateway Signed-off-by: haoqixu <hq.xu0o0@gmail.com> * refactor: continue early to reduce nesting Signed-off-by: haoqixu <hq.xu0o0@gmail.com> * refactor: rename envoyProxies and ClassEnvoyProxy Signed-off-by: haoqixu <hq.xu0o0@gmail.com> * rename json/yaml name for envoyproxy Signed-off-by: haoqixu <hq.xu0o0@gmail.com> * fix: pass the right envoyProxy to t.IsEnvoyServiceRouting Signed-off-by: haoqixu <hq.xu0o0@gmail.com> * test: add more cases Signed-off-by: haoqixu <hq.xu0o0@gmail.com> * chore: regenerate Signed-off-by: haoqixu <hq.xu0o0@gmail.com> --------- Signed-off-by: haoqixu <hq.xu0o0@gmail.com> Signed-off-by: bjlhlin <lihonglin1@jd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Support attaching
EnvoyProxyresource to Gateways ifMergeGatewaysis disabled onGatewayClass.This PR only implements the controller part and does not implement the
egctlpart. I would like to submit another PR for theegctlpart.Which issue(s) this PR fixes: