Skip to content

fix: set path prefix for http ext auth service#3018

Merged
zhaohuabing merged 2 commits intoenvoyproxy:mainfrom
zhaohuabing:ext-auth-http-path-prefix
Mar 26, 2024
Merged

fix: set path prefix for http ext auth service#3018
zhaohuabing merged 2 commits intoenvoyproxy:mainfrom
zhaohuabing:ext-auth-http-path-prefix

Conversation

@zhaohuabing
Copy link
Copy Markdown
Member

@zhaohuabing zhaohuabing requested a review from a team as a code owner March 26, 2024 03:07
@zhaohuabing zhaohuabing marked this pull request as draft March 26, 2024 03:07
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
@zhaohuabing zhaohuabing force-pushed the ext-auth-http-path-prefix branch from 3490987 to 3402a02 Compare March 26, 2024 03:11
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.62%. Comparing base (b98893a) to head (2fe5efb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3018      +/-   ##
==========================================
- Coverage   64.63%   64.62%   -0.02%     
==========================================
  Files         121      121              
  Lines       21131    21135       +4     
==========================================
  Hits        13658    13658              
- Misses       6624     6627       +3     
- Partials      849      850       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaohuabing zhaohuabing marked this pull request as ready for review March 26, 2024 03:16
@zhaohuabing zhaohuabing enabled auto-merge (squash) March 26, 2024 03:17
@zhaohuabing zhaohuabing merged commit 2882b7c into envoyproxy:main Mar 26, 2024
@arkodg
Copy link
Copy Markdown
Contributor

arkodg commented Mar 26, 2024

can we also add this into e2e ?

@zhaohuabing
Copy link
Copy Markdown
Member Author

can we also add this into e2e ?

The mock HTTP ext auth service for e2e doesn't care about path :-(

const server = new Http.Server((req, res) => {
const authorization = req.headers["authorization"] || "";
const extracted = authorization.split(" ");
if (extracted.length === 2 && extracted[0] === "Bearer") {
const user = checkToken(extracted[1]);
console.log(`token: "${extracted[1]}" user: "${user}`);
if (user !== undefined) {
// The authorization server returns a response with "x-current-user" header for a successful
// request.
res.writeHead(200, { "x-current-user": user });
return res.end();
}
}
res.writeHead(403);
res.end();

yaelSchechter pushed a commit to yaelSchechter/envoy-gateway that referenced this pull request Mar 28, 2024
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
Signed-off-by: Yael Shechter <yael.shechter@sap.com>
arkodg added a commit that referenced this pull request Mar 28, 2024
* build(deps): bump github.com/prometheus/common from 0.50.0 to 0.51.1 (#3010)

Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.50.0 to 0.51.1.
- [Release notes](https://github.com/prometheus/common/releases)
- [Commits](prometheus/common@v0.50.0...v0.51.1)

---
updated-dependencies:
- dependency-name: github.com/prometheus/common
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* docs: fix squash link (#3013)

Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* api: support IdleTimeout in clientTrafficPolicy

Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* build(deps): bump fortio.org/fortio from 1.63.4 to 1.63.5 (#3011)

Bumps [fortio.org/fortio](https://github.com/fortio/fortio) from 1.63.4 to 1.63.5.
- [Release notes](https://github.com/fortio/fortio/releases)
- [Commits](fortio/fortio@v1.63.4...v1.63.5)

---
updated-dependencies:
- dependency-name: fortio.org/fortio
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* ci: trigger docs action (#3017)

Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* ci: fix cherrypick permission (#2985)

Signed-off-by: zirain <zirain2009@gmail.com>
Co-authored-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* fix: set path prefix for http ext auth service (#3018)

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* feat: add Chinese language support for doc site (#2532)

* Add Chinese support for doc site

Signed-off-by: Wilson Wu <iwilsonwu@gmail.com>

* Add zh i18n for menus

Signed-off-by: Wilson Wu <iwilsonwu@gmail.com>

* Add zh content placeholders

Signed-off-by: Wilson Wu <iwilsonwu@gmail.com>

* Fix about zh page

Signed-off-by: Wilson Wu <iwilsonwu@gmail.com>

* Apply suggestions from code review

Co-authored-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Wilson Wu <iwilsonwu@gmail.com>

* docs: `%s/Application/API/g` (#2929)

Signed-off-by: Wilson Wu <iwilsonwu@gmail.com>

* remove old version for zh content

Signed-off-by: Wilson Wu <iwilsonwu@gmail.com>

* Update the latest version link

Signed-off-by: Wilson Wu <iwilsonwu@gmail.com>

* Fix default content dir

Signed-off-by: Wilson Wu <iwilsonwu@gmail.com>

* Translate landing page and fix broken link

Signed-off-by: Wilson Wu <iwilsonwu@gmail.com>

* Fix broken link

Signed-off-by: Wilson Wu <iwilsonwu@gmail.com>

* Add a contribution page

Signed-off-by: Wilson Wu <iwilsonwu@gmail.com>

---------

Signed-off-by: Wilson Wu <iwilsonwu@gmail.com>
Co-authored-by: Huabing Zhao <zhaohuabing@gmail.com>
Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com>
Co-authored-by: zirain <zirain2009@gmail.com>
Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* feat(translator): implement connection limit (#2952)

* implement connection limit

Signed-off-by: Guy Daich <guy.daich@sap.com>

* fix lint

Signed-off-by: Guy Daich <guy.daich@sap.com>

* fix lint 2

Signed-off-by: Guy Daich <guy.daich@sap.com>

* fix ir, coverage

Signed-off-by: Guy Daich <guy.daich@sap.com>

* fix lint 3

Signed-off-by: Guy Daich <guy.daich@sap.com>

* open more connection in e2e

Signed-off-by: Guy Daich <guy.daich@sap.com>

* fix error type

Signed-off-by: Guy Daich <guy.daich@sap.com>

* add additional connections

Signed-off-by: Guy Daich <guy.daich@sap.com>

* make limit value required

Signed-off-by: Guy Daich <guy.daich@sap.com>

* add error-flow unit test

Signed-off-by: Guy Daich <guy.daich@sap.com>

* fix lint 4

Signed-off-by: Guy Daich <guy.daich@sap.com>

* assert policy accepted in test

Signed-off-by: Guy Daich <guy.daich@sap.com>

* rename limit => connectionLimit

Signed-off-by: Guy Daich <guy.daich@sap.com>

---------

Signed-off-by: Guy Daich <guy.daich@sap.com>
Co-authored-by: zirain <zirain2009@gmail.com>
Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* docs: remove 0.1.0  from linkinator ignore list (#3015)

Signed-off-by: yuluo <karashouk.pan@gmail.com>
Co-authored-by: zirain <zirain2009@gmail.com>
Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* disable connection limit test (#3025)

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* fix: use correct connection limit attribute name in e2e, docs (#3028)

fix attribute name

Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* docs: document patches in envoy proxy (#3027)

* docs: document patches in envoy proxy

Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* fix linting issue

Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* fix pr comment

Signed-off-by: Yael Shechter <yael.shechter@sap.com>

---------

Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* feat(policy): Adding BTP support for UDP/TCPRoute (#3004)

* Adding BTP support for UDP/TCP Routes

Signed-off-by: Alexander Volchok <alex.volchok@sap.com>

* fixining lint

Signed-off-by: Alexander Volchok <alex.volchok@sap.com>

* fix IdleTime check

Signed-off-by: Alexander Volchok <alex.volchok@sap.com>

* adding missing generates

Signed-off-by: Alexander Volchok <alex.volchok@sap.com>

* fixing code review comments

Signed-off-by: Alexander Volchok <alex.volchok@sap.com>

* incresing code coverage

Signed-off-by: Alexander Volchok <alex.volchok@sap.com>

---------

Signed-off-by: Alexander Volchok <alex.volchok@sap.com>
Co-authored-by: zirain <zirain2009@gmail.com>
Co-authored-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* fix: add missing http filters to the http filter chain (#2970)

* fix: add missing http filters to the http filter chain

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>

* refactor

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>

* fix lint

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>

* add comments

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>

* remove refactor

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>

* remove refactor

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>

* fix gen

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>

* fix lint

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

---------

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* fix pr comment

Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* ci: grant pull-requests permission to cherrypick action (#3039)

Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* Update ADOPTERS.md for Airspace Link (#3045)

Signed-off-by: Fabrice Aneche <akhenakh@users.noreply.github.com>
Co-authored-by: zirain <zirain2009@gmail.com>
Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* feat: added option to specify resources on the OIDC security policy (#3030)

added option to specify resources on the OIDC filter

Signed-off-by: jaynis <kranz.jannis@googlemail.com>
Co-authored-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* run make commands

Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* fix: allow websockets in url rewrite (#3022)

allow websockets in url rewrite

Signed-off-by: Jesse Haka <haka.jesse@gmail.com>
Co-authored-by: zirain <zirain2009@gmail.com>
Signed-off-by: Yael Shechter <yael.shechter@sap.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Yael Shechter <yael.shechter@sap.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
Signed-off-by: Wilson Wu <iwilsonwu@gmail.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: yuluo <karashouk.pan@gmail.com>
Signed-off-by: Alexander Volchok <alex.volchok@sap.com>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Fabrice Aneche <akhenakh@users.noreply.github.com>
Signed-off-by: jaynis <kranz.jannis@googlemail.com>
Signed-off-by: Jesse Haka <haka.jesse@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Huabing Zhao <zhaohuabing@gmail.com>
Co-authored-by: zirain <zirain2009@gmail.com>
Co-authored-by: Wilson Wu <iwilsonwu@gmail.com>
Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com>
Co-authored-by: Guy Daich <guy.daich@sap.com>
Co-authored-by: YuLuo <karashouk.pan@gmail.com>
Co-authored-by: Alex Volchok <alex.volchok@sap.com>
Co-authored-by: Fabrice Aneche <akhenakh@users.noreply.github.com>
Co-authored-by: jaynis <kranz.jannis@googlemail.com>
Co-authored-by: Jesse Haka <haka.jesse@gmail.com>
arkodg pushed a commit to arkodg/gateway that referenced this pull request Apr 8, 2024
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
(cherry picked from commit 2882b7c)
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Xunzhuo added a commit that referenced this pull request Apr 8, 2024
* Run certgen when upgrading (#2934)

run certgen when upgrading

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
(cherry picked from commit 62ecf15)
Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* Fix: nil secret in resourceversiontable (#2982)

* fix nil secret in resourceversiontable

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>

* check secrets in the xds result

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>

---------

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
(cherry picked from commit e880439)
Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* fix: add missing http filters to the http filter chain (#2970)

* fix: add missing http filters to the http filter chain

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>

* refactor

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>

* fix lint

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>

* add comments

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>

* remove refactor

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>

* remove refactor

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>

* fix gen

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>

* fix lint

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

---------

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
(cherry picked from commit f699edf)
Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* fix: allow websockets in url rewrite (#3022)

allow websockets in url rewrite

Signed-off-by: Jesse Haka <haka.jesse@gmail.com>
Co-authored-by: zirain <zirain2009@gmail.com>
(cherry picked from commit 3d51933)
Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* Set host for http health checker explicitly to avoid using the cluster name as host header for http health checking request. (#3057)

* Set host for http health checker explictly to avoid using the cluster name as host header for http health checking request

Signed-off-by: lemonlinger <lemonlinger@gmail.com>

* fix broken tests

Signed-off-by: lemonlinger <lemonlinger@gmail.com>

* fix health-check test case in xds translation

Signed-off-by: lemonlinger <lemonlinger@gmail.com>

* Simplify code and concise comments

Signed-off-by: lemonlinger <lemonlinger@gmail.com>

---------

Signed-off-by: lemonlinger <lemonlinger@gmail.com>
(cherry picked from commit 8f450a9)
Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* fix: do not create infra resources when missing translated listeners (#3043)

* fix: do not create infra resources when missing translated listeners

Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>

* remove empty line

Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>

* skip infra creation on empty listeners and log it

Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>

---------

Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
(cherry picked from commit 36d7141)
Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* Fix: double slashes in redirect URL (#2998)

* fix: double trailing splashs in redirect URL

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>

* add e2e tests

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>

* fix lint

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>

* fix test

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>

* fix test

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>

* fix test

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>

* fix test

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>

* add e2e tests

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>

* fix test

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>

* revert

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>

* use regex rewrite to generate the redirect url

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>

* use regex rewrite to generate the redirect url

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>

* use regex rewrite to generate the redirect url

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>

* remove comments

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>

* extract method

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>

* address comments

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>

---------

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
(cherry picked from commit ceb697f)
Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* fix: Allow Policy to attach to multiple http listeners  (#2967)

* Fixing the clienttrafficpolicy validation.

Signed-off-by: Lior Okman <lior.okman@sap.com>

* Make SecurityPolicy validate correctly.

Signed-off-by: Lior Okman <lior.okman@sap.com>

* Reverted the SecurityPolicy validation - handled differently via
another feature.

Signed-off-by: Lior Okman <lior.okman@sap.com>

* Updated the tests to reflect that this validation isn't required for SecurityPolicy

Signed-off-by: Lior Okman <lior.okman@sap.com>

* Added some comments to explain the validation being performed.

Signed-off-by: Lior Okman <lior.okman@sap.com>

* Updated the error message as requested in the review.

Signed-off-by: Lior Okman <lior.okman@sap.com>

---------

Signed-off-by: Lior Okman <lior.okman@sap.com>
(cherry picked from commit f9409e4)
Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* fix: set path prefix for http ext auth service (#3018)

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
(cherry picked from commit 2882b7c)
Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* Change route sorting order to Exact > RegularExpression > PathPrefix (#2579)

* Change route sorting order to Exact > RegularExpression > PathPrefix

kubernetes-sigs/gateway-api#1770
kubernetes-sigs/gateway-api#1855

Signed-off-by: Stéphane Cottin <stephane.cottin@vixns.com>
(cherry picked from commit 11f56fd)
Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* fix: infraIR duplicate port translation for merged gateways (#3061)

* fix: duplicate port translation for merged gateways

Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>

* refactor to map

Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>

* rename map

Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>

* add seperate testcase

Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>

---------

Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
(cherry picked from commit 29946b0)
Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* translator: set SpawnUpstreamSpan to true (#3102)

* translator: set SpawnUpstreamSpan to true

Signed-off-by: zirain <zirain2009@gmail.com>

* update

Signed-off-by: zirain <zirain2009@gmail.com>

---------

Signed-off-by: zirain <zirain2009@gmail.com>
(cherry picked from commit 635ebfc)
Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* fix: rate limit doesn't work with two(and more) listeners (#3085)

* fix: rate limit doesn't work with two listeners

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>

* add e2e test for rate limit on multiple listeners

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>

* address comments

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>

---------

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
Co-authored-by: Xunzhuo <bitliu@tencent.com>
(cherry picked from commit a5bedbc)
Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* rerun make testdata

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

---------

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Jesse Haka <haka.jesse@gmail.com>
Signed-off-by: lemonlinger <lemonlinger@gmail.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
Signed-off-by: Lior Okman <lior.okman@sap.com>
Signed-off-by: Stéphane Cottin <stephane.cottin@vixns.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Co-authored-by: Huabing Zhao <zhaohuabing@gmail.com>
Co-authored-by: Jesse Haka <haka.jesse@gmail.com>
Co-authored-by: zirain <zirain2009@gmail.com>
Co-authored-by: Meng <lemonlinger@gmail.com>
Co-authored-by: Karol Szwaj <karol.szwaj@gmail.com>
Co-authored-by: Lior Okman <lior.okman@sap.com>
Co-authored-by: vixns <stephane.cottin@vixns.com>
Co-authored-by: Xunzhuo <bitliu@tencent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

can't configure pathPrefix for extAuth

2 participants