Merged
Conversation
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3003 +/- ##
=======================================
Coverage 64.63% 64.63%
=======================================
Files 121 121
Lines 21124 21124
=======================================
Hits 13653 13653
Misses 6623 6623
Partials 848 848 ☔ View full report in Codecov by Sentry. |
zetaab
approved these changes
Mar 24, 2024
Member
|
/retest |
zirain
approved these changes
Mar 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #3001
Check for
access-control-expose-headershas been removed because CORS filter sets theaccess-control-expose-headersheader even when the origin is not allowed.https://github.com/envoyproxy/envoy/blob/b68af06271838f62abf80ac6a2f84b0b5c413d68/source/extensions/filters/http/cors/cors_filter.cc#L196-L198
This is a temporary workaround. It might be an upstream bug introduced by envoyproxy/envoy#33051.
Related upstream issue: envoyproxy/envoy#33086