cors: return local reply when preflight origin does not match allowed origins#33051
Merged
mattklein123 merged 3 commits intoenvoyproxy:mainfrom Mar 22, 2024
Merged
cors: return local reply when preflight origin does not match allowed origins#33051mattklein123 merged 3 commits intoenvoyproxy:mainfrom
mattklein123 merged 3 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
mattklein123
approved these changes
Mar 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
cors: return local reply when preflight origin does not match allowed origins
Additional Description:
When CORS preflight's origin does not match configured allowed origins, the filter continued iteration. The preflight reached the upstream server. Some users expressed interest in generating local reply in such situation. Based on CORS specs, locally generated reply should not contain
access-control-allow-originresponse header. This behaviour is controlled by API and default setting is to forward the preflight to upstream.Risk Level: Low
Testing: Added unit/integration tests.
Docs Changes: Yes
Release Notes: Yes
Platform Specific Features: No
Fixes #14233