Skip to content

Add support for exposing additional bootstrap config options#243

Merged
arkodg merged 2 commits intoenvoyproxy:mainfrom
NomadXD:fix/issue-212
Aug 25, 2022
Merged

Add support for exposing additional bootstrap config options#243
arkodg merged 2 commits intoenvoyproxy:mainfrom
NomadXD:fix/issue-212

Conversation

@NomadXD
Copy link
Copy Markdown
Contributor

@NomadXD NomadXD commented Aug 25, 2022

With #206, only the Xds server address is configurable. This PR add support to configure Xds server port, admin server host and port.

Fixes #212

Signed-off-by: Lahiru De Silva lahirude@wso2.com

Signed-off-by: Lahiru De Silva <lahirude@wso2.com>
Signed-off-by: Lahiru De Silva <lahirude@wso2.com>
@NomadXD NomadXD requested a review from a team as a code owner August 25, 2022 13:55
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #243 (5168c8e) into main (d99f32f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #243      +/-   ##
==========================================
+ Coverage   57.62%   57.63%   +0.01%     
==========================================
  Files          30       30              
  Lines        2702     2703       +1     
==========================================
+ Hits         1557     1558       +1     
  Misses       1054     1054              
  Partials       91       91              
Impacted Files Coverage Δ
internal/infrastructure/kubernetes/deployment.go 82.50% <100.00%> (+0.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Copy Markdown
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks !

@arkodg arkodg merged commit 98f73f8 into envoyproxy:main Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose Additional Bootstrap Config Options

3 participants