Conversation
Codecov Report
@@ Coverage Diff @@
## main #206 +/- ##
==========================================
- Coverage 63.60% 63.23% -0.37%
==========================================
Files 27 27
Lines 2349 2358 +9
==========================================
- Hits 1494 1491 -3
- Misses 768 776 +8
- Partials 87 91 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: danehans <daneyonhansen@gmail.com>
Alice-Lilith
left a comment
There was a problem hiding this comment.
bootstrap looks good to me
LukeShu
left a comment
There was a problem hiding this comment.
Some nits that you can choose to ignore. On the whole, lgtm.
| envoyHTTPSPort = int32(8443) | ||
| ) | ||
|
|
||
| var bootstrapTmpl = template.Must(template.New(envoyCfgFileName).Parse(` |
There was a problem hiding this comment.
I'd consider putting this in a separate bootstrap.yaml file and saying
//go:embed bootstrap.yaml
const string bootstrapTmplStr
var bootstrapTmpl = template.Must(template.New(envoyCfgFileName).Parse(bootstrapTmplStr))so that the file is easier to edit, with editors recognizing it as yaml.
| buf := new(bytes.Buffer) | ||
| if err := bootstrapTmpl.Execute(buf, b.parameters); err != nil { | ||
| return fmt.Errorf("failed to render bootstrap config: %v", err) | ||
| } | ||
| b.rendered = buf.String() |
There was a problem hiding this comment.
If we never need access it as a []byte or mutate it (other than append), then it'd be more efficient to use a strings.Builder instead of a bytes.Buffer.
Adds support for managing Envoy's bootstrap config through a ConfigMap.
Fixes: #201
Signed-off-by: danehans daneyonhansen@gmail.com