api: Support connection timeouts in BackendTrafficPolicy#2411
api: Support connection timeouts in BackendTrafficPolicy#2411zirain merged 5 commits intoenvoyproxy:mainfrom
Conversation
0f08873 to
2f65997
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2411 +/- ##
=======================================
Coverage 64.65% 64.65%
=======================================
Files 115 115
Lines 17364 17364
=======================================
Hits 11227 11227
Misses 5425 5425
Partials 712 712 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
prefer timeout here, we've used singular terms in all fields in this API.
Also connection prefix is not needed imo
api/v1alpha1/timeout_types.go
Outdated
There was a problem hiding this comment.
should we create top level tcp and http fields here ?
There was a problem hiding this comment.
Seeing as there are several other HTTP (stream, ...) and TCP (proxy, protocol, ...) timeouts that could be relevant in the future, it makes sense to me.
There was a problem hiding this comment.
why this pass ci? let me double check it.
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
194a083 to
a0f04f4
Compare
api/v1alpha1/timeout_types.go
Outdated
| // Default: unlimited. | ||
| // | ||
| // +optional | ||
| ConnectionDuration *gwapiv1.Duration `json:"connectionDuration,omitempty"` |
There was a problem hiding this comment.
maxConnectionDuration instead ?
api/v1alpha1/timeout_types.go
Outdated
| // +optional | ||
| ConnectionIdleTimeout *gwapiv1.Duration `json:"connectionIdleTimeout,omitempty"` | ||
|
|
||
| // The maximum duration of an persistent HTTPTimeout connections. |
There was a problem hiding this comment.
The maximum duration of an HTTP connection.
Signed-off-by: Guy Daich <guy.daich@sap.com>
|
/retest |
…2411) * API: Support Connection Timeouts in BackendTrafficPolicy Signed-off-by: Guy Daich <guy.daich@sap.com> * code review fixes Signed-off-by: Guy Daich <guy.daich@sap.com> * code review fixes 2 Signed-off-by: Guy Daich <guy.daich@sap.com> --------- Signed-off-by: Guy Daich <guy.daich@sap.com> Signed-off-by: A3bz <zeng921359373@163.com>
What this PR does / why we need it:
Allow users to configure various upstream timeout options.
Which issue(s) this PR fixes:
Fixes #2401, relates to #1821