feat: remove AuthenticationFilter in favor of SecurityPolicy#2086
Merged
arkodg merged 1 commit intoenvoyproxy:mainfrom Oct 27, 2023
Merged
feat: remove AuthenticationFilter in favor of SecurityPolicy#2086arkodg merged 1 commit intoenvoyproxy:mainfrom
arkodg merged 1 commit intoenvoyproxy:mainfrom
Conversation
Member
Author
|
The code is ready for review while I'm working on the docs. |
b3afb58 to
e68cd5d
Compare
e68cd5d to
04e18c4
Compare
Codecov Report
@@ Coverage Diff @@
## main #2086 +/- ##
==========================================
- Coverage 64.41% 64.22% -0.20%
==========================================
Files 109 107 -2
Lines 15094 14626 -468
==========================================
- Hits 9723 9393 -330
+ Misses 4768 4666 -102
+ Partials 603 567 -36
|
07d42b0 to
4726428
Compare
Member
|
kindly reminder: you need rebase once #2081 merged. |
bf3525c to
86414b7
Compare
Contributor
|
@zhaohuabing you will also need to delete and recreate the |
86414b7 to
53c4691
Compare
Member
How about raising an issue for it ? @arkodg |
Xunzhuo
reviewed
Oct 27, 2023
Member
Xunzhuo
left a comment
There was a problem hiding this comment.
Well done, some docs lint errors need to be resolved.
Xunzhuo
reviewed
Oct 27, 2023
Member
Author
|
This PR only adds docs for JWT, CORS docs will be taken care of in a follow-up PR. |
51f572e to
0b5472d
Compare
Signed-off-by: huabing zhao <zhaohuabing@gmail.com> fix e2e Signed-off-by: huabing zhao <zhaohuabing@gmail.com> fix test and add policies to egctl translate command Signed-off-by: huabing zhao <zhaohuabing@gmail.com> add docs for jwt Signed-off-by: huabing zhao <zhaohuabing@gmail.com> remove crd Signed-off-by: huabing zhao <zhaohuabing@gmail.com> clear docs Signed-off-by: huabing zhao <zhaohuabing@gmail.com> address comments Signed-off-by: huabing zhao <zhaohuabing@gmail.com> update security policy status Signed-off-by: huabing zhao <zhaohuabing@gmail.com> fix e2e test Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
8f37d30 to
9ea96a9
Compare
Member
Author
zirain
approved these changes
Oct 27, 2023
This was referenced Oct 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes
AuthenticationFilter. The existing JWT authentication inAuthenticationFilterhas been replaced bySecurityPolicy. The other planned authn features (OIDC, Basic Auth, etc.) will be incorporated into `SecurityPolicy as well in the future.Related: #2079
Fix: #2082