Skip to content

feat: add jwt authn to SecurityPolicy#2079

Merged
zirain merged 3 commits intoenvoyproxy:mainfrom
zhaohuabing:securitypolicy-jwt
Oct 26, 2023
Merged

feat: add jwt authn to SecurityPolicy#2079
zirain merged 3 commits intoenvoyproxy:mainfrom
zhaohuabing:securitypolicy-jwt

Conversation

@zhaohuabing
Copy link
Copy Markdown
Member

@zhaohuabing zhaohuabing commented Oct 26, 2023 •
edited
Loading

What type of PR is this?
This PR adds JWT Authentication to the SecurityPolicy.

Related issue: #1845

This feature is intended to replace the JWT Authn configuration in the existing AuthenticationFilter. AuthenticationFilter will be removed in a follow-up PR.

@zhaohuabing zhaohuabing requested a review from a team as a code owner October 26, 2023 04:43
zhaohuabing
zhaohuabing commented Oct 26, 2023
View reviewed changes
@zhaohuabing zhaohuabing force-pushed the securitypolicy-jwt branch 4 times, most recently from bd4c47d to d05611d Compare October 26, 2023 05:57
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 26, 2023 •
edited
Loading

Codecov Report

Merging #2079 (be3d207) into main (6b8794e) will increase coverage by 0.14%.
The diff coverage is 72.86%.

@@            Coverage Diff             @@
##             main    #2079      +/-   ##
==========================================
+ Coverage   64.32%   64.46%   +0.14%     
==========================================
  Files         107      109       +2     
  Lines       14944    15299     +355     
==========================================
+ Hits         9613     9863     +250     
- Misses       4739     4820      +81     
- Partials      592      616      +24
Files Coverage Δ
api/v1alpha1/validation/authenticationfilter.go 86.56% <ø> (ø)
internal/gatewayapi/securitypolicy.go 78.60% <100.00%> (+2.34%) ⬆️
internal/xds/translator/authentication.go 71.81% <75.00%> (-1.66%) ⬇️
internal/xds/translator/translator.go 79.51% <0.00%> (-0.84%) ⬇️
api/v1alpha1/validation/securitypolicy_validate.go 94.36% <94.36%> (ø)
internal/ir/xds.go 71.39% <45.45%> (-2.72%) ⬇️
internal/xds/translator/httpfilters.go 72.36% <25.00%> (-5.90%) ⬇️
internal/ir/zz_generated.deepcopy.go 11.72% <0.00%> (-0.25%) ⬇️
internal/xds/translator/jwt_authn.go 73.36% <73.36%> (ø)

... and 2 files with indirect coverage changes

@zhaohuabing zhaohuabing requested review from arkodg and zirain October 26, 2023 06:08
@zhaohuabing
add jwt authn to SecurityPolicy
2cb43ba 
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
@zhaohuabing
rename JWTAuthentication to JWT
4f58641 
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
@zhaohuabing
fix test
be3d207 
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
arkodg
arkodg approved these changes Oct 26, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested review from a team, Xunzhuo, tanujd11 and tmsnan and removed request for a team October 26, 2023 19:12
@zirain zirain merged commit c3ee960 into envoyproxy:main Oct 26, 2023
@zhaohuabing zhaohuabing mentioned this pull request Oct 27, 2023
Merged
This was referenced Nov 16, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zirain zirain zirain approved these changes

@arkodg arkodg arkodg approved these changes

@tmsnan tmsnan Awaiting requested review from tmsnan tmsnan was automatically assigned from envoyproxy/gateway-reviewers

@Xunzhuo Xunzhuo Awaiting requested review from Xunzhuo Xunzhuo was automatically assigned from envoyproxy/gateway-reviewers

@tanujd11 tanujd11 Awaiting requested review from tanujd11 tanujd11 was automatically assigned from envoyproxy/gateway-reviewers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zhaohuabing @zirain @arkodg