Skip to content

feat: CORS ir and xds translation#2016

Merged
arkodg merged 2 commits intoenvoyproxy:mainfrom
zhaohuabing:xds-ir-cors
Oct 22, 2023
Merged

feat: CORS ir and xds translation#2016
arkodg merged 2 commits intoenvoyproxy:mainfrom
zhaohuabing:xds-ir-cors

Conversation

@zhaohuabing
Copy link
Copy Markdown
Member

@zhaohuabing zhaohuabing commented Oct 19, 2023 •
edited
Loading

This PR does the following:

  • Adds ir and xds translation for CORS.
    The CORS will be part of the SecurityPolicy API. The API and translation to ir will be included in a subsequent PR after the SecurityPolicy PR has been completed.

  • Sorts the HTTP filter in a rational order after patching all filters to the HCM filter chain, so each individual filter translator doesn't have to care about its own order anymore.

Relates to #567

@zhaohuabing zhaohuabing requested a review from a team as a code owner October 19, 2023 08:16
@zhaohuabing zhaohuabing marked this pull request as draft October 19, 2023 08:16
@zhaohuabing zhaohuabing force-pushed the xds-ir-cors branch 2 times, most recently from 57e53c5 to 40e41fe Compare October 19, 2023 09:12
@zhaohuabing zhaohuabing marked this pull request as ready for review October 19, 2023 09:12
@zhaohuabing zhaohuabing requested a review from arkodg October 19, 2023 09:13
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 19, 2023 •
edited
Loading

Codecov Report

Merging #2016 (fa3b523) into main (c59ced0) will increase coverage by 0.03%.
The diff coverage is 55.92%.

@@            Coverage Diff             @@
##             main    #2016      +/-   ##
==========================================
+ Coverage   65.33%   65.36%   +0.03%     
==========================================
  Files          93       95       +2     
  Lines       13727    13929     +202     
==========================================
+ Hits         8968     9105     +137     
- Misses       4205     4259      +54     
- Partials      554      565      +11
Files Coverage Δ
internal/ir/xds.go 74.10% <ø> (ø)
internal/xds/translator/listener.go 82.64% <0.00%> (-0.22%) ⬇️
internal/xds/translator/route.go 92.14% <0.00%> (+0.97%) ⬆️
internal/xds/translator/httpfilters.go 78.26% <78.26%> (ø)
internal/xds/translator/cors.go 65.97% <65.97%> (ø)
internal/ir/zz_generated.deepcopy.go 11.97% <0.00%> (-0.56%) ⬇️

... and 2 files with indirect coverage changes

@zhaohuabing zhaohuabing force-pushed the xds-ir-cors branch 2 times, most recently from 2466e33 to 51517c5 Compare October 19, 2023 13:46
@zhaohuabing zhaohuabing marked this pull request as draft October 19, 2023 14:28
arkodg
arkodg reviewed Oct 19, 2023
View reviewed changes
arkodg
arkodg reviewed Oct 19, 2023
View reviewed changes
arkodg
arkodg reviewed Oct 19, 2023
View reviewed changes
arkodg
arkodg reviewed Oct 19, 2023
View reviewed changes
arkodg
arkodg reviewed Oct 19, 2023
View reviewed changes
arkodg
arkodg reviewed Oct 19, 2023
View reviewed changes
@arkodg
Copy link
Copy Markdown
Contributor

arkodg commented Oct 19, 2023

thanks for picking this one up @zhaohuabing, added some minor comments

@zhaohuabing zhaohuabing marked this pull request as ready for review October 20, 2023 01:22
@zhaohuabing zhaohuabing force-pushed the xds-ir-cors branch 4 times, most recently from 0bdc33d to 1d7f30f Compare October 20, 2023 03:24
@zhaohuabing zhaohuabing requested a review from arkodg October 20, 2023 03:25
@zhaohuabing zhaohuabing requested review from a team, Alice-Lilith, Xunzhuo and kflynn and removed request for a team October 20, 2023 04:18
@zhaohuabing zhaohuabing requested a review from a team October 20, 2023 04:18
arkodg
arkodg reviewed Oct 20, 2023
View reviewed changes
arkodg
arkodg reviewed Oct 20, 2023
View reviewed changes
arkodg
arkodg reviewed Oct 20, 2023
View reviewed changes
@zhaohuabing zhaohuabing force-pushed the xds-ir-cors branch 2 times, most recently from 596400e to b8fc9d7 Compare October 21, 2023 12:03
@zhaohuabing zhaohuabing requested a review from arkodg October 21, 2023 12:03
@zhaohuabing
cors ir and xds translation
755b032 
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>

sort HTTP filters

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>

address comments

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>

refactor route filter config

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>

address comments

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
@zhaohuabing
Remove AllowPrivateNetworkAccess since it's not a common knob
fa3b523 
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
arkodg
arkodg approved these changes Oct 22, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm thanks !

@arkodg arkodg merged commit c1d03de into envoyproxy:main Oct 22, 2023
@zhaohuabing zhaohuabing mentioned this pull request Oct 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zirain zirain zirain approved these changes

@arkodg arkodg arkodg approved these changes

@kflynn kflynn Awaiting requested review from kflynn kflynn was automatically assigned from envoyproxy/gateway-reviewers

@Alice-Lilith Alice-Lilith Awaiting requested review from Alice-Lilith Alice-Lilith was automatically assigned from envoyproxy/gateway-reviewers

@Xunzhuo Xunzhuo Awaiting requested review from Xunzhuo Xunzhuo was automatically assigned from envoyproxy/gateway-reviewers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zhaohuabing @arkodg @zirain