Merged
Conversation
arkodg
reviewed
Oct 12, 2023
arkodg
reviewed
Oct 12, 2023
Contributor
|
also needs a status eq check in gateway/internal/status/status.go Line 172 in 57b00ed |
Member
Author
|
Hold this until BackendTrafficPolicy is done since these two have similar structures and the latter is in a better shape now. |
1340d36 to
f1ede3e
Compare
f1ede3e to
9b18692
Compare
Codecov Report
@@ Coverage Diff @@
## main #1957 +/- ##
==========================================
- Coverage 65.25% 65.16% -0.10%
==========================================
Files 97 99 +2
Lines 14199 14400 +201
==========================================
+ Hits 9266 9384 +118
- Misses 4359 4434 +75
- Partials 574 582 +8
|
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
9b18692 to
f010cd5
Compare
Member
Author
|
If this is acceptable, I'd like to add design and user docs of SecurityPolicy later when we have a concrete feature coming in, like CORS or JWT. |
arkodg
approved these changes
Oct 24, 2023
zirain
approved these changes
Oct 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a shameless copy && paste from @arkodg 's BackendTrafficPolicy, with replacing key word from "BackendTraffic" to "Security".
The processing of the listener layer is missing in both the BackendTrafficPolicy and SecurityPolicy. Considering the tight deadline of 0.6, we can keep this as is and improve it in 0.7.
Relates to #1845