Skip to content

Remove attributes from request cookies#663

Merged
phlax merged 1 commit intoenvoyproxy:mainfrom
zhaohuabing:fix-request-token
Jun 16, 2025
Merged

Remove attributes from request cookies#663
phlax merged 1 commit intoenvoyproxy:mainfrom
zhaohuabing:fix-request-token

Conversation

@zhaohuabing
Copy link
Copy Markdown
Member

@zhaohuabing zhaohuabing commented Jun 15, 2025

The current verify script directly use the content of the set-cookie response header as the cookie in a request. This PR removes the cookie attributes which should not be included in the request cookie header.

This fix unblocks envoyproxy/envoy#39059

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
@zhaohuabing
Copy link
Copy Markdown
Member Author

zhaohuabing commented Jun 15, 2025

cc @phlax

Copy link
Copy Markdown
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @zhaohuabing

@phlax phlax merged commit a0b5627 into envoyproxy:main Jun 16, 2025
4 checks passed
@zhaohuabing
Copy link
Copy Markdown
Member Author

zhaohuabing commented Jun 16, 2025

Hi @phlax Thanks a lot for the quick review! Should I patch this in my pr, or wait for this change lands in envoy?

@zhaohuabing zhaohuabing deleted the fix-request-token branch June 16, 2025 13:17
@phlax
Copy link
Copy Markdown
Member

phlax commented Jun 16, 2025

i was going to raise an update fairly imminently in envoy - just trying to clear dep update backlog first

ggmoy added a commit to ggmoy/envoyproxy-examples that referenced this pull request Aug 15, 2025
Signed-off-by: Gustavo Moyano <gustavo.g.moyano@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants